Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1322523002: Make WorkerScriptLoader back to RefCounted class (Closed)

Created:
5 years, 3 months ago by kinuko
Modified:
5 years, 3 months ago
CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make WorkerScriptLoader back to RefCounted class This was made non-refcounted class in https://crrev.com/1190133002, but looks like this could cause crashes in some corner cases. To be more specific: FrameLoaderClientImpl::dispatchDidFinishDocumentLoad() calls WebFrameClient callback first and then WebView callback next, but if the loader is deleted in the first callback an attempt to call the second callback on a member variable would crash. We could probably avoid this crash without making the loader class ref-counted again, but for now I would like to fix the crash by simply reverting some of the changes that're causing the crash. BUG=524694 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M Source/core/workers/InProcessWorkerBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/InProcessWorkerBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/workers/WorkerScriptLoader.h View 3 chunks +11 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerScriptLoader.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
kinuko
Could you review? ksakamoto or falken: worker script loader changes tkent-san: web changes
5 years, 3 months ago (2015-08-27 08:10:41 UTC) #3
Kunihiko Sakamoto
On 2015/08/27 08:10:41, kinuko wrote: > Could you review? > > ksakamoto or falken: worker ...
5 years, 3 months ago (2015-08-27 08:20:05 UTC) #4
kinuko
On 2015/08/27 08:20:05, Kunihiko Sakamoto wrote: > On 2015/08/27 08:10:41, kinuko wrote: > > Could ...
5 years, 3 months ago (2015-08-27 08:28:28 UTC) #5
Kunihiko Sakamoto
lgtm
5 years, 3 months ago (2015-08-27 08:36:22 UTC) #6
tkent
lgtm
5 years, 3 months ago (2015-08-27 23:25:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322523002/1
5 years, 3 months ago (2015-08-28 00:01:39 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 00:06:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201346

Powered by Google App Engine
This is Rietveld 408576698