Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1322513003: Multicol: Min-height should have no effect if content is taller and height is auto. (Closed)

Created:
5 years, 3 months ago by mstensho (USE GERRIT)
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Multicol: Min-height should have no effect if content is taller and height is auto. Calling computeLogicalHeight() before layout is somewhat problematic, since we don't know the content/intrinsic height at that point. Specifying that height as 0 would return the value of min-height (if specified) and make the multicol code believe that height is constrained, and prevent columns from getting any taller than that. In other words, min-height was more or less treated as max-height in multicol. Since we only want to know if we have a non-auto height that could constrain the column heights, we can just skip computeLogicalHeight() if height is indefinite. BUG=65731 R=jchaffraix@chromium.org,leviw@chromium.org Committed: https://crrev.com/79a9f512a11425ca0e55243dc10628f45484feb9 git-svn-id: svn://svn.chromium.org/blink/trunk@202162 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : LayoutView also has to call computeLogicalHeight(). Its height is kinda definite. #

Patch Set 3 : Use block instead of inline in test, so that we don't have to make assumptions about internal leadi… #

Messages

Total messages: 17 (6 generated)
mstensho (USE GERRIT)
5 years, 3 months ago (2015-09-09 20:19:00 UTC) #1
mstensho (USE GERRIT)
pling
5 years, 3 months ago (2015-09-11 12:04:43 UTC) #2
leviw_travelin_and_unemployed
lgtm plong I'm gonna slowly be working my way through my backlogs here. Apologies for ...
5 years, 3 months ago (2015-09-11 15:13:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322513003/20001
5 years, 3 months ago (2015-09-11 15:13:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/105939)
5 years, 3 months ago (2015-09-11 16:24:28 UTC) #7
mstensho (USE GERRIT)
On 2015/09/11 15:13:17, leviw OOO thru 9-9 )( wrote: > lgtm > > plong > ...
5 years, 3 months ago (2015-09-11 17:29:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322513003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322513003/40001
5 years, 3 months ago (2015-09-11 17:45:56 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/106033)
5 years, 3 months ago (2015-09-11 18:51:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322513003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322513003/40001
5 years, 3 months ago (2015-09-11 18:56:09 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202162
5 years, 3 months ago (2015-09-11 20:26:31 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:26:06 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/79a9f512a11425ca0e55243dc10628f45484feb9

Powered by Google App Engine
This is Rietveld 408576698