Source/web/WebDevToolsFrontendImpl.h - Issue 1322513002: [Oilpan] Add a GC_PLUGIN_IGNORE with a TODO comment

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/WebDevToolsFrontendImpl.h

Issue 1322513002: [Oilpan] Add a GC_PLUGIN_IGNORE with a TODO comment (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Revert and put TODO comment Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55	55

56 void sendMessageToEmbedder(const WTF::String&) override;	56 void sendMessageToEmbedder(const WTF::String&) override;

57	57

58 bool isUnderTest() override;	58 bool isUnderTest() override;

59	59

60 void showContextMenu(LocalFrame*, float x, float y, PassRefPtrWillBeRawPtr<C ontextMenuProvider>) override;	60 void showContextMenu(LocalFrame*, float x, float y, PassRefPtrWillBeRawPtr<C ontextMenuProvider>) override;

61	61

62 void setInjectedScriptForOrigin(const String& origin, const String& source) override;	62 void setInjectedScriptForOrigin(const String& origin, const String& source) override;

63	63

64 private:	64 private:

	65 // TODO(Oilpan): Make the lifetime of m_webFrame clear to remove this GC_PLU GIN_IGNORE.

	66 GC_PLUGIN_IGNORE("http://crbug.com/509911")

65 WebLocalFrameImpl* m_webFrame;	67 WebLocalFrameImpl* m_webFrame;

66 WebDevToolsFrontendClient* m_client;	68 WebDevToolsFrontendClient* m_client;

67 RefPtrWillBePersistent<DevToolsHost> m_devtoolsHost;	69 RefPtrWillBePersistent<DevToolsHost> m_devtoolsHost;

68 typedef HashMap<String, String> InjectedScriptForOriginMap;	70 typedef HashMap<String, String> InjectedScriptForOriginMap;

69 InjectedScriptForOriginMap m_injectedScriptForOrigin;	71 InjectedScriptForOriginMap m_injectedScriptForOrigin;

70 };	72 };

71	73

72 } // namespace blink	74 } // namespace blink

73	75

74 #endif	76 #endif

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »