Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2135)

Unified Diff: Source/modules/presentation/PresentationAvailability.h

Issue 1322493006: Presentation API: ignore page visibility changes if ExecutionContext is destoyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/presentation/PresentationAvailability.h
diff --git a/Source/modules/presentation/PresentationAvailability.h b/Source/modules/presentation/PresentationAvailability.h
index 82e1f7d60f5756a762a03d4d1c7cc85887863110..07c302feabc7dce701b4e9930231821cd0247a2c 100644
--- a/Source/modules/presentation/PresentationAvailability.h
+++ b/Source/modules/presentation/PresentationAvailability.h
@@ -8,6 +8,7 @@
#include "core/dom/ActiveDOMObject.h"
#include "core/events/EventTarget.h"
#include "core/page/PageLifecycleObserver.h"
+#include "modules/ModulesExport.h"
#include "platform/weborigin/KURL.h"
#include "public/platform/WebURL.h"
#include "public/platform/modules/presentation/WebPresentationAvailabilityObserver.h"
@@ -21,7 +22,7 @@ class ScriptPromiseResolver;
// object will be initialized with a default value passed via ::take() and will
// then subscribe to receive callbacks if the status for |url| were to
// change. The object will only listen to changes when required.
-class PresentationAvailability final
+class MODULES_EXPORT PresentationAvailability final
: public RefCountedGarbageCollectedEventTargetWithInlineData<PresentationAvailability>
, public ActiveDOMObject
, public PageLifecycleObserver
@@ -30,9 +31,6 @@ class PresentationAvailability final
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(PresentationAvailability);
DEFINE_WRAPPERTYPEINFO();
public:
- // For CallbackPromiseAdapter.
- using WebType = bool;
-
static PresentationAvailability* take(ScriptPromiseResolver*, const KURL&, bool);
~PresentationAvailability() override;

Powered by Google App Engine
This is Rietveld 408576698