Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1322463002: [sqlite] Respect the gyp and gn component switch. (Closed)

Created:
5 years, 3 months ago by Scott Hess - ex-Googler
Modified:
5 years, 3 months ago
Reviewers:
michaeln
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sqlite] Respect the gyp and gn component switch. SQLITE_API is the existing mechanism SQLite provides, and is used in preference to inventing a new SQLITE_EXPORT symbol (like sql/sql_export.h and other examples). CoreServices.framework is necessary on OSX because of the Time Machine patch. Remove sql/proxy.{h,cc}, which was necessary to work around SQLite linking statically into both component shlibs and unit test executables. BUG=489444 Committed: https://crrev.com/4ec68d9ad2d3e0c74967a17946c8bf7ed4450f73 Cr-Commit-Position: refs/heads/master@{#346151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -80 lines) Patch
M sql/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M sql/connection_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
D sql/proxy.h View 1 chunk +0 lines, -39 lines 0 comments Download
D sql/proxy.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M sql/sql.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 3 chunks +18 lines, -1 line 0 comments Download
M third_party/sqlite/sqlite.gyp View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Scott Hess - ex-Googler
Apologies for the steampunk nature of the SQLITE_API defines - I was not able to ...
5 years, 3 months ago (2015-08-27 05:47:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322463002/1
5 years, 3 months ago (2015-08-27 05:47:44 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-27 06:12:23 UTC) #6
michaeln
On 2015/08/27 05:47:25, Scott Hess wrote: > Apologies for the steampunk nature of the SQLITE_API ...
5 years, 3 months ago (2015-08-27 22:47:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322463002/1
5 years, 3 months ago (2015-08-28 14:08:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 15:22:24 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4ec68d9ad2d3e0c74967a17946c8bf7ed4450f73 Cr-Commit-Position: refs/heads/master@{#346151}
5 years, 3 months ago (2015-08-28 15:22:56 UTC) #11
sergeyv
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1324523004/ by sergeyv@chromium.org. ...
5 years, 3 months ago (2015-08-28 17:46:32 UTC) #12
Scott Hess - ex-Googler
5 years, 3 months ago (2015-08-28 19:27:55 UTC) #13
Message was sent while issue was closed.
Fixed version landing at:
   https://codereview.chromium.org/1325513002/

Powered by Google App Engine
This is Rietveld 408576698