Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2318)

Issue 1322403002: dart2js cps: Change interceptor pipeline. (Closed)

Created:
5 years, 3 months ago by asgerf
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Change interceptor pipeline. Interceptor sharing/hoisting now takes places much later. ShareInterceptors is now responsible for replacing interceptor calls with constants, although determining if it CAN be replaced with a constant is determined during type propagation where precise types are available. LetSinking has been removed; it was a leftover from when interceptors were generated at definition-site. As a follow-up on deleting LetSinking, creation expressions are now considered effectively constant during assignment propagation. This is safe because such expressions are not propagated into loops (this was not always the case). BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/e5fc507c7873cea5d0b5db17a76b7bee3cddc463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -138 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 2 chunks +13 lines, -1 line 0 comments Download
D pkg/compiler/lib/src/cps_ir/let_sinking.dart View 1 chunk +0 lines, -119 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimizers.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/share_interceptors.dart View 4 chunks +53 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +3 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 3 months ago (2015-09-04 10:56:03 UTC) #2
Kevin Millikin (Google)
lgtm
5 years, 3 months ago (2015-09-07 09:21:17 UTC) #3
asgerf
5 years, 3 months ago (2015-09-07 17:08:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e5fc507c7873cea5d0b5db17a76b7bee3cddc463 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698