Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5969)

Unified Diff: chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc

Issue 13224004: Bluetooth: remove private members from BluetoothAdapter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix BluetoothApiTest.Events Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc
diff --git a/chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc b/chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc
index 05ab6f3d8b924cc0bdda861e789dbf0cef247cbe..934440fb38e156cbd6a97db1e69c2dde675ba754 100644
--- a/chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc
+++ b/chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc
@@ -8,20 +8,12 @@
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
-namespace {
-
-const char* kAdapterAddress = "Mock Adapter address for testing";
-const char* kName = "Mock Adapter name for testing";
-
-} // namespace
-
namespace extensions {
class ExtensionBluetoothEventRouterTest : public testing::Test {
public:
ExtensionBluetoothEventRouterTest()
Mark Mentovai 2013/04/02 18:05:27 This constructor should be explicit.
keybuk 2013/04/02 19:03:09 I'm confused as to why this would be explicit? ex
Mark Mentovai 2013/04/02 19:30:24 keybuk wrote:
- : mock_adapter_(new testing::StrictMock<device::MockBluetoothAdapter>(
- kAdapterAddress, kName)),
+ : mock_adapter_(new testing::StrictMock<device::MockBluetoothAdapter>),
youngki 2013/04/02 12:30:31 put parentheses () .
Mark Mentovai 2013/04/02 18:05:27 Nobody deletes this?
keybuk 2013/04/02 19:03:09 Done.
router_(&test_profile_) {
router_.SetAdapterForTest(mock_adapter_);
}

Powered by Google App Engine
This is Rietveld 408576698