DDC: mostly incremental compilation, fixes #223

test/codegen_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Tests code generation.
 /// Runs Dart Dev Compiler on all input in the `codegen` directory and checks
 /// that the output is what we expected.
 library dev_compiler.test.codegen_test;
 
 import 'dart:io';
@@ skipping 21 matching lines @@
       .listSync()
       .where((f) => f is File)
       .map((f) => f.path)
       .where((p) => p.endsWith('.dart') && filePattern.hasMatch(p));
 }
 
 main(arguments) {
   if (arguments == null) arguments = [];
   ArgResults args = argParser.parse(arguments);
   var filePattern = new RegExp(args.rest.length > 0 ? args.rest[0] : '.');
-  var compilerMessages = new StringBuffer();
-  var loggerSub;
-
-  setUp(() {
-    compilerMessages.clear();
-    loggerSub = setupLogger(Level.CONFIG, compilerMessages.writeln);
-  });
-
-  tearDown(() {
-    if (loggerSub != null) {
-      loggerSub.cancel();
-      loggerSub = null;
-    }
-  });
 
   var inputDir = path.join(testDirectory, 'codegen');
   var expectDir = path.join(inputDir, 'expect');
 
   bool compile(String entryPoint, AnalysisContext context,
       {bool checkSdk: false, bool sourceMaps: false, bool closure: false}) {
     // TODO(jmesserly): add a way to specify flags in the test file, so
     // they're more self-contained.
     var runtimeDir = path.join(path.dirname(testDirectory), 'lib', 'runtime');
     var options = new CompilerOptions(
         codegenOptions: new CodegenOptions(
             outputDir: expectDir,
             emitSourceMaps: sourceMaps,
             closure: closure,
             forceCompile: checkSdk),
         useColors: false,
         checkSdk: checkSdk,
         runtimeDir: runtimeDir,
         inputs: [entryPoint],
-        inputBaseDir: inputDir);
+        inputBaseDir: inputDir,
+        saveMessages: true);
     var reporter = createErrorReporter(context, options);
     return new BatchCompiler(context, options, reporter: reporter).run();
   }
 
   {
     // Expand wacky multitests into a bunch of test files.
     // We'll compile each one as if it was an input.
     var languageDir = path.join(inputDir, 'language');
     var testFiles = _findTests(languageDir, filePattern);
 
@@ skipping 17 matching lines @@
           outcomes.remove('runtime error');
           if (outcomes.isNotEmpty) {
             // Skip all other outcomes.
             //
             // They are handled by analyzer/static type system, and
             // therefore are not interesting to run.
             tests.remove(name);
           }
         });
 
+        var modifyTime = new File(filePath).lastModifiedSync();
         var filename = path.basenameWithoutExtension(filePath);
         tests.forEach((name, contents) {
-          new File(path.join(languageDir, '${filename}_${name}_multi.dart'))
-              .writeAsStringSync(contents);
+          var f = new File(
+              path.join(languageDir, '${filename}_${name}_multi.dart'));
+          if (!f.existsSync() || f.lastModifiedSync().isBefore(modifyTime)) {
+            f.writeAsStringSync(contents);
+          }
         });
       }
     }
   }
 
   for (var dir in [null, 'language']) {
     group('dartdevc ' + path.join('test', 'codegen', dir), () {
       var outDir = path.join(expectDir, dir);
 
       var testFiles = _findTests(path.join(inputDir, dir), filePattern);
       for (var filePath in testFiles) {
         var filename = path.basenameWithoutExtension(filePath);
 
         test('$filename.dart', () {
-          compilerMessages.writeln('// Messages from compiling $filename.dart');
-
           // TODO(jmesserly): this was added to get some coverage of source maps
           // and closure annotations.
           // We need a more comprehensive strategy to test them.
           var sourceMaps = filename == 'map_keys';
           var closure = filename == 'closure';
-          var success = compile(filePath, realSdkContext,
+          compile(filePath, realSdkContext,
               sourceMaps: sourceMaps, closure: closure);
 
-          // Write compiler messages to disk.
-          new File(path.join(outDir, '$filename.txt'))
-              .writeAsStringSync('$compilerMessages');
+          var messageFile = new File(path.join(outDir, '$filename.txt'));
+          var jsFile = new File(path.join(outDir, '$filename.js'));
 
-          var outFile = new File(path.join(outDir, '$filename.js'));
-          expect(outFile.existsSync(), success,
-              reason: '${outFile.path} was created iff compilation succeeds');
+          bool error = false;
+          if (messageFile.existsSync()) {
+            var messageContents = messageFile.readAsStringSync();
+            error = messageContents.contains('severe');
+          }
+
+          expect(jsFile.existsSync() == !error, true,
+              reason: 'JS file should exist iff no errors were found.');
         });
       }
     });
   }
 
   if (Platform.environment.containsKey('COVERALLS_TOKEN')) {
     group('sdk', () {
       // The analyzer does not bubble exception messages for certain internal
       // dart:* library failures, such as failing to find
       // "_internal/libraries.dart". Instead it produces an opaque "failed to
@@ skipping 23 matching lines @@
             reason: '${outFile.path} was created for dart:core');
       });
     });
   }
 
   var expectedRuntime =
       defaultRuntimeFiles.map((f) => 'dev_compiler/runtime/$f');
 
   test('devc jscodegen sunflower.html', () {
     var filePath = path.join(inputDir, 'sunflower', 'sunflower.html');
-    compilerMessages.writeln('// Messages from compiling sunflower.html');
-
-    var success = compile(filePath, realSdkContext);
-
-    // Write compiler messages to disk.
-    new File(path.join(expectDir, 'sunflower', 'sunflower.txt'))
-        .writeAsStringSync(compilerMessages.toString());
+    compile(filePath, realSdkContext);
 
     var expectedFiles = ['sunflower.html', 'sunflower.js',];
 
     for (var filepath in expectedFiles) {
       var outFile = new File(path.join(expectDir, 'sunflower', filepath));
-      expect(outFile.existsSync(), success,
-          reason: '${outFile.path} was created iff compilation succeeds');
+      expect(outFile.existsSync(), true, reason: '${outFile.path} was created');
     }
   });
 
   test('devc jscodegen html_input.html', () {
     var filePath = path.join(inputDir, 'html_input.html');
-    compilerMessages.writeln('// Messages from compiling html_input.html');
-
-    var success = compile(filePath, realSdkContext);
-
-    // Write compiler messages to disk.
-    new File(path.join(expectDir, 'html_input.txt'))
-        .writeAsStringSync(compilerMessages.toString());
+    compile(filePath, realSdkContext);
 
     var expectedFiles = [
       'html_input.html',
       'dir/html_input_a.js',
       'dir/html_input_b.js',
       'dir/html_input_c.js',
       'dir/html_input_d.js',
       'dir/html_input_e.js'
     ]..addAll(expectedRuntime);
 
     for (var filepath in expectedFiles) {
       var outFile = new File(path.join(expectDir, filepath));
-      expect(outFile.existsSync(), success,
-          reason: '${outFile.path} was created iff compilation succeeds');
+      expect(outFile.existsSync(), true, reason: '${outFile.path} was created');
     }
   });
 }
 
 /// An implementation of analysis engine's [Logger] that prints.
 class PrintLogger implements Logger {
   @override void logError(String message, [CaughtException exception]) {
     print('[AnalysisEngine] error $message $exception');
   }
 
   @override void logError2(String message, Object exception) {
     print('[AnalysisEngine] error $message $exception');
   }
 
   void logInformation(String message, [CaughtException exception]) {}
   void logInformation2(String message, Object exception) {}
 }