Synchronize is-valid flag upon programmatic clearing of file.value

Synchronize is-valid flag upon programmatic clearing of file.value

If a type=file input element is cleared of its current contents by
setting the "value" property to the empty string, make sure the 'is
valid' flag kept on the input element is synchronized.

Failure to do so could incorrectly make the element pass follow-on
validation -- if it additionally has 'required' set.

R=tkent@chromium.org
BUG=336818
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166115

[sof, 2014-01-29 15:28:01]

Please take a look when you next have a spare moment.

[tkent, 2014-01-29 23:36:26]

lgtm

https://codereview.chromium.org/132233059/diff/1/LayoutTests/fast/forms/file/...
File LayoutTests/fast/forms/file/file-input-empty-validation.html (right):

https://codereview.chromium.org/132233059/diff/1/LayoutTests/fast/forms/file/...
LayoutTests/fast/forms/file/file-input-empty-validation.html:40:
testRunner.dumpAsText();
nit: You don't need dumpAsText().  js-test.js calls it.

https://codereview.chromium.org/132233059/diff/1/LayoutTests/fast/forms/file/...
LayoutTests/fast/forms/file/file-input-empty-validation.html:41:
testRunner.waitUntilDone();
nit: You don't need dumpAsText().  js-test.js calls it if jsTestIsAsync is set.

[tkent, 2014-01-29 23:37:35]

On 2014/01/29 23:36:26, tkent wrote:
> testRunner.waitUntilDone();
> nit: You don't need dumpAsText().  js-test.js calls it if jsTestIsAsync is
set.

dumpAsText -> waitUntilDone

[sof, 2014-01-30 06:24:47]

On 2014/01/29 23:37:35, tkent wrote:
> On 2014/01/29 23:36:26, tkent wrote:
> > testRunner.waitUntilDone();
> > nit: You don't need dumpAsText().  js-test.js calls it if jsTestIsAsync is
> set.
> 
> dumpAsText -> waitUntilDone

Ah, so it does via the DOMContentLoaded handler. Will fix.

[commit-bot: I haz the power, 2014-01-30 07:34:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/132233059/20001

[commit-bot: I haz the power, 2014-01-30 09:38:56]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2014-01-30 09:39:41]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-30 09:51:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/132233059/20001

[commit-bot: I haz the power, 2014-01-30 09:51:55]

Change committed as 166115

[commit-bot: I haz the power, 2014-01-30 09:52:15]

CQ bit was unchecked on CL. Ignoring.