Issue 132233058: Revert 247164 "Implement browser-side logging to WebRtc log"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132233058: Revert 247164 "Implement browser-side logging to WebRtc log" (Closed)

Created:
6 years, 10 months ago by vrk (LEFT CHROMIUM)

Modified:
6 years, 10 months ago

Reviewers:
vrk (LEFT CHROMIUM)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 247164 "Implement browser-side logging to WebRtc log" Need to revert this because it's causing crashes on Canary. BUG=338848 > Implement browser-side logging to WebRtc log > > This adds a logging callback to RenderProcessHost and also adds logging > for device enumeration in the browser process. > > BUG=332261 > > Review URL: https://codereview.chromium.org/140843007 TBR=vrk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247548

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -222 lines)			Patch
M	trunk/src/chrome/browser/chrome_content_browser_client.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/media/webrtc_logging_handler_host.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/media/webrtc_logging_handler_host.cc	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/audio_input_renderer_host.cc	View	3 chunks	+0 lines, -6 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/desktop_capture_device.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/desktop_capture_device_aura.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/desktop_capture_device_aura_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/desktop_capture_device_unittest.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/media_stream_manager.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/media_stream_manager.cc	View	5 chunks	+1 line, -97 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/video_capture_controller.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/video_capture_controller_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/video_capture_device_impl.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/video_capture_device_impl.cc	View	4 chunks	+11 lines, -15 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/video_capture_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/web_contents_video_capture_device.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/web_contents_video_capture_device_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_process_host_impl.h	View	3 chunks	+0 lines, -11 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_process_host_impl.cc	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	trunk/src/content/public/browser/render_process_host.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	trunk/src/content/public/test/mock_render_process_host.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/content/public/test/mock_render_process_host.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/media/video/capture/android/video_capture_device_android.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/media/video/capture/linux/video_capture_device_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/media/video/capture/mac/video_capture_device_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/media/video/capture/video_capture_device.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/media/video/capture/video_capture_device_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/media/video/capture/win/video_capture_device_mf_win.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	trunk/src/media/video/capture/win/video_capture_device_win.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/media/video/capture/win/video_capture_device_win.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r247548.

Expand Messages | Collapse Messages