Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 132233042: Enable the embedded L1/EME support in WebView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed boliu's comments and rebased. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 7921262064b3b3a91f7fa48be457f97fc2e933f7..99f91b33f321f8b76ff7239546b91767b45e5121 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -2560,8 +2560,7 @@ public class ContentViewCore
mBrowserAccessibilityManager.notifyFrameInfoInitialized();
}
- // Update geometry for external video surface.
- getContentViewClient().onGeometryChanged(-1, null);
+ getContentViewClient().onExternalVideoSurfaceRenderCoordinatesChanged();
}
@CalledByNative
@@ -3256,10 +3255,20 @@ public class ContentViewCore
}
@CalledByNative
- private void notifyExternalSurface(
- int playerId, boolean isRequest, float x, float y, float width, float height) {
- if (isRequest) getContentViewClient().onExternalVideoSurfaceRequested(playerId);
- getContentViewClient().onGeometryChanged(playerId, new RectF(x, y, x + width, y + height));
+ private void requestExternalVideoSurface(int playerId) {
+ getContentViewClient().onRequestExternalVideoSurface(playerId);
+ }
+
+ @CalledByNative
+ private void releaseExternalVideoSurface(int playerId) {
+ getContentViewClient().onReleaseExternalVideoSurface(playerId);
+ }
+
+ @CalledByNative
+ private void notifyExternalVideoSurfacePositionChanged(
+ int playerId, float x, float y, float width, float height) {
+ getContentViewClient().onExternalVideoSurfacePositionChanged(
+ playerId, new RectF(x, y, x + width, y + height));
Ted C 2014/02/11 18:05:47 what coordinate space are these values (css pixels
ycheo (away) 2014/02/14 07:41:04 css pixels, updates in the javadoc.
}
public void extractSmartClipData(int x, int y, int width, int height) {

Powered by Google App Engine
This is Rietveld 408576698