Chromium Code Reviews| Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java |
| diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java |
| index d4d388dbb616e9604c81d27db3736a681416fc6d..7b99870a47544b5cb597552708b115af8ca09784 100644 |
| --- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java |
| +++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java |
| @@ -2445,9 +2445,6 @@ public class ContentViewCore |
| if (mBrowserAccessibilityManager != null) { |
| mBrowserAccessibilityManager.notifyFrameInfoInitialized(); |
| } |
| - |
| - // Update geometry for external video surface. |
| - getContentViewClient().onGeometryChanged(-1, null); |
|
boliu
2014/01/24 21:56:32
So what happens when the page scrolls/zooms now? I
boliu
2014/01/25 01:27:39
Never mind. Found the renderer code to update geom
boliu
2014/01/25 04:50:13
Err, scratch that. Renderer commit is only updatin
ycheo (away)
2014/01/28 13:08:53
I was wrong.
In case of the scroll, this was not n
|
| } |
| @CalledByNative |
| @@ -3147,8 +3144,8 @@ public class ContentViewCore |
| @CalledByNative |
| private void notifyExternalSurface( |
| int playerId, boolean isRequest, float x, float y, float width, float height) { |
| - if (isRequest) getContentViewClient().onExternalVideoSurfaceRequested(playerId); |
| - getContentViewClient().onGeometryChanged(playerId, new RectF(x, y, x + width, y + height)); |
| + getContentViewClient().onExternalVideoSurfaceNotified( |
| + this, playerId, isRequest, new RectF(x, y, x + width, y + height)); |
|
boliu
2014/01/24 21:56:32
This is a bit of a layering violation here. We sho
ycheo (away)
2014/01/28 13:08:53
Done.
|
| } |
| public void extractSmartClipData(int x, int y, int width, int height) { |