Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 132233031: Build with configuration_policy enabled on iOS by default. (Closed)

Created:
6 years, 11 months ago by Joao da Silva
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joaodasilva+watch_chromium.org
Visibility:
Public.

Description

Build with configuration_policy enabled on iOS by default. This will start covering the policy iOS build on the main waterfall. The code in chrome/browser/policy is still disabled on that platform by default, but the policy component and its unittests will be built. This change also enables one policy on iOS, otherwise some parts of the build break. BUG=275292 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246422

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -24 lines) Patch
M build/common.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 2 chunks +20 lines, -9 lines 1 comment Download
M components/policy/core/common/generate_policy_source_unittest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/policy/resources/policy_templates.json View 1 2 13 chunks +73 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Joao da Silva
PTAL, thanks!
6 years, 11 months ago (2014-01-21 17:56:53 UTC) #1
Joao da Silva
+Jochen for components/components_tests.gyp Maybe you have a better idea to get those unittests on ios? ...
6 years, 11 months ago (2014-01-21 18:47:29 UTC) #2
Joao da Silva
Now with +Jochen for real @Jochen: PTAL at components/components_tests.gyp Maybe you have a better idea ...
6 years, 11 months ago (2014-01-21 18:48:28 UTC) #3
dconnelly
lgtm
6 years, 11 months ago (2014-01-22 10:09:43 UTC) #4
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/132233031/diff/100001/components/components_tests.gyp File components/components_tests.gyp (right): https://codereview.chromium.org/132233031/diff/100001/components/components_tests.gyp#newcode272 components/components_tests.gyp:272: # these files excluded as expected. that comment ...
6 years, 11 months ago (2014-01-22 11:28:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/132233031/100001
6 years, 11 months ago (2014-01-22 19:10:26 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 21:48:06 UTC) #7
Message was sent while issue was closed.
Change committed as 246422

Powered by Google App Engine
This is Rietveld 408576698