Issue 132233018: In a chromium checkout, compile d8 for the host toolset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132233018: In a chromium checkout, compile d8 for the host toolset (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 11 months ago

Reviewers:
Michael Achenbach

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

In a chromium checkout, compile d8 for the host toolset It's required during compilation on the host for webui tests BUG=331585 R=machenbach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245515

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	build/common.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/132233018/1

6 years, 11 months ago (2014-01-17 12:43:24 UTC) #3

jochen (gone - plz use gerrit)

Committed patchset #1 manually as r245515 (presubmit successful).

6 years, 11 months ago (2014-01-17 14:17:44 UTC) #4

Sheridan Rawlins

6 years, 11 months ago (2014-01-17 23:44:49 UTC) #5

Message was sent while issue was closed.

On 2014/01/17 14:17:44, jochen wrote:
> Committed patchset #1 manually as r245515 (presubmit successful).

Does this unblock https://codereview.chromium.org/138923005/ or is there still
more effort to go to build/use d8#host instead of v8_shell#host?

Expand Messages | Collapse Messages