Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Unified Diff: Source/core/svg/SVGAnimatedType.cpp

Issue 132233016: [SVG] SVGAnimatedPointList migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: set NeedsRebaseline Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGAnimatedType.h ('k') | Source/core/svg/SVGAnimatorFactory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGAnimatedType.cpp
diff --git a/Source/core/svg/SVGAnimatedType.cpp b/Source/core/svg/SVGAnimatedType.cpp
index b0b2635b963c0b8cda0c498fa91b2d30a02df82a..7a67e97c4609d473b61cb979bf202e3a73aa1e3b 100644
--- a/Source/core/svg/SVGAnimatedType.cpp
+++ b/Source/core/svg/SVGAnimatedType.cpp
@@ -61,9 +61,6 @@ SVGAnimatedType::~SVGAnimatedType()
case AnimatedPath:
delete m_data.path;
break;
- case AnimatedPoints:
- delete m_data.pointList;
- break;
case AnimatedPreserveAspectRatio:
delete m_data.preserveAspectRatio;
break;
@@ -78,8 +75,15 @@ SVGAnimatedType::~SVGAnimatedType()
case AnimatedLength:
case AnimatedLengthList:
case AnimatedRect:
+ case AnimatedPoints:
// handled by RefPtr
break;
+
+ // There is no SVGAnimatedPoint
+ case AnimatedPoint:
+ ASSERT_NOT_REACHED();
+ break;
+
case AnimatedUnknown:
ASSERT_NOT_REACHED();
break;
@@ -158,14 +162,6 @@ PassOwnPtr<SVGAnimatedType> SVGAnimatedType::createPath(PassOwnPtr<SVGPathByteSt
return animatedType.release();
}
-PassOwnPtr<SVGAnimatedType> SVGAnimatedType::createPointList(SVGPointList* pointList)
-{
- ASSERT(pointList);
- OwnPtr<SVGAnimatedType> animatedType = adoptPtr(new SVGAnimatedType(AnimatedPoints));
- animatedType->m_data.pointList = pointList;
- return animatedType.release();
-}
-
PassOwnPtr<SVGAnimatedType> SVGAnimatedType::createPreserveAspectRatio(SVGPreserveAspectRatio* preserveAspectRatio)
{
ASSERT(preserveAspectRatio);
@@ -214,6 +210,7 @@ String SVGAnimatedType::valueAsString()
// Below properties have migrated to new property implementation.
case AnimatedLength:
case AnimatedLengthList:
+ case AnimatedPoints:
case AnimatedRect:
return m_newProperty->valueAsString();
@@ -226,7 +223,7 @@ String SVGAnimatedType::valueAsString()
case AnimatedNumberList:
case AnimatedNumberOptionalNumber:
case AnimatedPath:
- case AnimatedPoints:
+ case AnimatedPoint:
case AnimatedPreserveAspectRatio:
case AnimatedTransformList:
case AnimatedUnknown:
@@ -257,6 +254,7 @@ bool SVGAnimatedType::setValueAsString(const QualifiedName& attrName, const Stri
// Below properties have migrated to new property implementation.
case AnimatedLength:
case AnimatedLengthList:
+ case AnimatedPoints:
case AnimatedRect:
// Always use createForAnimation call path for these implementations.
return false;
@@ -270,7 +268,7 @@ bool SVGAnimatedType::setValueAsString(const QualifiedName& attrName, const Stri
case AnimatedNumberList:
case AnimatedNumberOptionalNumber:
case AnimatedPath:
- case AnimatedPoints:
+ case AnimatedPoint:
case AnimatedPreserveAspectRatio:
case AnimatedTransformList:
case AnimatedUnknown:
« no previous file with comments | « Source/core/svg/SVGAnimatedType.h ('k') | Source/core/svg/SVGAnimatorFactory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698