[SVG] SVGAnimatedPointList migration to new SVG property impl.

Source/core/svg/SVGPoint.cpp

+/*
+ * Copyright (C) 2014 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+
+#include "core/svg/SVGPoint.h"
+
+#include "bindings/v8/ExceptionState.h"
+#include "core/dom/ExceptionCode.h"
+#include "core/svg/SVGAnimationElement.h"
+#include "core/svg/SVGParserUtilities.h"
+#include "platform/transforms/AffineTransform.h"
+#include "wtf/text/StringBuilder.h"
+#include "wtf/text/WTFString.h"
+
+namespace WebCore {
+
+SVGPoint::SVGPoint()
+    : NewSVGPropertyBase(classType())
+{
+}
+
+SVGPoint::SVGPoint(const FloatPoint& point)
+    : NewSVGPropertyBase(classType())
+    , m_value(point)
+{
+}
+
+PassRefPtr<SVGPoint> SVGPoint::clone() const
+{
+    return SVGPoint::create(m_value);
+}
+
+PassRefPtr<NewSVGPropertyBase> SVGPoint::cloneForAnimation(const String& value) const
+{
+    RefPtr<SVGPoint> point = SVGPoint::create();
+    point->setValueAsString(value, IGNORE_EXCEPTION);
+    return point.release();
+}
+
+template<typename CharType>
+void SVGPoint::parse(const CharType*& ptr, const CharType* end, ExceptionState& exceptionState)
+{
+    const CharType* start = ptr;
+
+    skipOptionalSVGSpaces(ptr, end);
+
+    float x = 0.0f;
+    float y = 0.0f;
+    bool valid = parseNumber(ptr, end, x) && parseNumber(ptr, end, y, false);
+
+    if (!valid) {
+        exceptionState.throwDOMException(SyntaxError, "Problem parsing point \"" + String(start, end - start) + "\"");
+        return;
+    }
+
+    skipOptionalSVGSpaces(ptr, end);
+    if (ptr < end) { // nothing should come after the last, fourth number
+        exceptionState.throwDOMException(SyntaxError, "Problem parsing point \"" + String(start, end - start) + "\"");
+        return;
+    }
+
+    m_value = FloatPoint(x, y);
+}
+
+FloatPoint SVGPoint::matrixTransform(const AffineTransform& transform) const
+{
+    double newX, newY;
+    transform.map(static_cast<double>(x()), static_cast<double>(y()), newX, newY);
+    return FloatPoint::narrowPrecision(newX, newY);
+}
+
+void SVGPoint::setValueAsString(const String& string, ExceptionState& exceptionState)
+{
+    if (string.isNull() || string.isEmpty()) {

[haraken, 2014/01/17 11:50:18]

string.isEmpty() implies string.isNull(), so you don't need string.isNull().

[kouhei (in TOK), 2014/01/20 01:10:26]

Done.

+        m_value = FloatPoint(0.0f, 0.0f);
+        return;
+    }
+
+    if (string.is8Bit()) {
+        const LChar* ptr = string.characters8();
+        const LChar* end = ptr + string.length();
+        parse(ptr, end, exceptionState);
+        return;
+    }
+
+    const UChar* ptr = string.characters16();
+    const UChar* end = ptr + string.length();
+    parse(ptr, end, exceptionState);
+}
+
+String SVGPoint::valueAsString() const
+{
+    StringBuilder builder;
+    builder.append(String::number(x()));
+    builder.append(' ');
+    builder.append(String::number(y()));
+    return builder.toString();
+}
+
+void SVGPoint::add(PassRefPtr<NewSVGPropertyBase> other, SVGElement*)
+{
+    // SVGPoint is not animated by itself
+    ASSERT_NOT_REACHED();
+}
+
+void SVGPoint::calculateAnimatedValue(SVGAnimationElement* animationElement, float percentage, unsigned repeatCount, PassRefPtr<NewSVGPropertyBase> fromValue, PassRefPtr<NewSVGPropertyBase> toValue, PassRefPtr<NewSVGPropertyBase> toAtEndOfDurationValue, SVGElement*)
+{
+    // SVGPoint is not animated by itself
+    ASSERT_NOT_REACHED();
+}
+
+float SVGPoint::calculateDistance(PassRefPtr<NewSVGPropertyBase> to, SVGElement* contextElement)
+{
+    // SVGPoint is not animated by itself

[haraken, 2014/01/17 11:50:18]

Shouldn't this be a FIXME?

FIXME: Distance calculation is not possible for SVGPoint right now. We need the
distance for every single value.

[kouhei (in TOK), 2014/01/20 01:10:26]

This shouldn't be a FIXME. SVGPoint is never animated by itself (only its list
is animated), so calculateDistance is not needed. This is used for paced
animation.
http://www.w3.org/TR/SVG/animate.html#complexDistances

+    ASSERT_NOT_REACHED();
+}
+
+}