[SVG] SVGAnimatedPointList migration to new SVG property impl.

Source/core/rendering/svg/SVGPathData.cpp

 /*
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 54 matching lines @@
     SVGLengthContext lengthContext(element);
     path.moveTo(FloatPoint(line->x1()->currentValue()->value(lengthContext), line->y1()->currentValue()->value(lengthContext)));
     path.addLineTo(FloatPoint(line->x2()->currentValue()->value(lengthContext), line->y2()->currentValue()->value(lengthContext)));
 }
 
 static void updatePathFromPathElement(SVGElement* element, Path& path)
 {
     buildPathFromByteStream(toSVGPathElement(element)->pathByteStream(), path);
 }
 
+static void updatePathFromPolylineElement(SVGElement* element, Path& path)
+{
+    RefPtr<SVGPointList> points = toSVGPolyElement(element)->points()->currentValue();
+    if (points->isEmpty())
+        return;
+
+    SVGPointList::ConstIterator it = points->begin();
+    SVGPointList::ConstIterator itEnd = points->end();
+    ASSERT(it != itEnd);
+    path.moveTo(it->value());
+    ++it;
+
+    for (; it != itEnd; ++it)
+        path.addLineTo(it->value());

[haraken, 2014/01/17 11:50:18]

In the previous code, we didn't call addLineTo for the first element. However,
in the new code, we're calling addLineTo for the first element. Is it OK?

[kouhei (in TOK), 2014/01/20 01:10:26]

We are not calling addLineTo for the first element. See line 85.

+}
+
 static void updatePathFromPolygonElement(SVGElement* element, Path& path)
 {
-    SVGPointList& points = toSVGPolygonElement(element)->pointsCurrentValue();
-    if (points.isEmpty())
-        return;
-
-    path.moveTo(points.first());
-
-    unsigned size = points.size();
-    for (unsigned i = 1; i < size; ++i)
-        path.addLineTo(points.at(i));
-
+    updatePathFromPolylineElement(element, path);

[haraken, 2014/01/17 11:50:18]

What's the advantage of introducing this static method?

[kouhei (in TOK), 2014/01/20 01:10:26]

This is for <polygon> element. The above is for <polyline> element.

     path.closeSubpath();
 }
 
-static void updatePathFromPolylineElement(SVGElement* element, Path& path)
-{
-    SVGPointList& points = toSVGPolylineElement(element)->pointsCurrentValue();
-    if (points.isEmpty())
-        return;
-
-    path.moveTo(points.first());
-
-    unsigned size = points.size();
-    for (unsigned i = 1; i < size; ++i)
-        path.addLineTo(points.at(i));
-}
-
 static void updatePathFromRectElement(SVGElement* element, Path& path)
 {
     SVGRectElement* rect = toSVGRectElement(element);
 
     SVGLengthContext lengthContext(element);
     float width = rect->width()->currentValue()->value(lengthContext);
     if (width <= 0)
         return;
     float height = rect->height()->currentValue()->value(lengthContext);
     if (height <= 0)
@@ skipping 33 matching lines @@
         map->set(SVGNames::polygonTag.localName().impl(), updatePathFromPolygonElement);
         map->set(SVGNames::polylineTag.localName().impl(), updatePathFromPolylineElement);
         map->set(SVGNames::rectTag.localName().impl(), updatePathFromRectElement);
     }
 
     if (PathUpdateFunction pathUpdateFunction = map->get(element->localName().impl()))
         (*pathUpdateFunction)(element, path);
 }
 
 } // namespace WebCore