Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 132233012: Revert "Implement in-heap backing store for typed arrays." (Closed)

Created:
6 years, 11 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert "Implement in-heap backing store for typed arrays." This reverts commit r18646 for breaking Win32 build. TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+638 lines, -1597 lines) Patch
M include/v8.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/arm/lithium-arm.cc View 4 chunks +16 lines, -16 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 8 chunks +20 lines, -65 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/elements.cc View 11 chunks +47 lines, -178 lines 0 comments Download
M src/elements-kind.h View 3 chunks +2 lines, -27 lines 0 comments Download
M src/elements-kind.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/factory.cc View 2 chunks +1 line, -15 lines 0 comments Download
M src/heap.h View 4 chunks +0 lines, -25 lines 0 comments Download
M src/heap.cc View 4 chunks +268 lines, -228 lines 0 comments Download
M src/heap-inl.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 6 chunks +10 lines, -18 lines 0 comments Download
M src/hydrogen-instructions.h View 9 chunks +16 lines, -47 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 10 chunks +6 lines, -31 lines 0 comments Download
M src/ia32/lithium-ia32.h View 3 chunks +1 line, -16 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 4 chunks +18 lines, -18 lines 0 comments Download
M src/ic.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.h View 8 chunks +0 lines, -113 lines 0 comments Download
M src/objects.cc View 9 chunks +3 lines, -116 lines 0 comments Download
M src/objects-debug.cc View 3 chunks +2 lines, -46 lines 0 comments Download
M src/objects-inl.h View 11 chunks +4 lines, -181 lines 0 comments Download
M src/objects-printer.cc View 4 chunks +64 lines, -80 lines 0 comments Download
M src/objects-visiting.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/objects-visiting.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/objects-visiting-inl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/runtime.cc View 2 chunks +1 line, -11 lines 0 comments Download
M src/stub-cache.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M src/third_party/valgrind/valgrind.h View 16 chunks +22 lines, -22 lines 0 comments Download
M src/third_party/vtune/jitprofiling.h View 7 chunks +46 lines, -46 lines 0 comments Download
M src/third_party/vtune/jitprofiling.cc View 14 chunks +20 lines, -20 lines 0 comments Download
M src/third_party/vtune/v8-vtune.h View 2 chunks +11 lines, -11 lines 0 comments Download
M src/third_party/vtune/vtune-jit.h View 2 chunks +11 lines, -11 lines 0 comments Download
M src/third_party/vtune/vtune-jit.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 6 chunks +8 lines, -36 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/x64/lithium-x64.cc View 3 chunks +19 lines, -20 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +8 lines, -114 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dmitry Lomov (no reviews)
Committed patchset #1 manually as r18647 (tree was closed).
6 years, 11 months ago (2014-01-16 14:26:42 UTC) #1
Jakob Kummerow
6 years, 11 months ago (2014-01-16 14:28:12 UTC) #2
Message was sent while issue was closed.
rubberstamp LGTM

Powered by Google App Engine
This is Rietveld 408576698