Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Unified Diff: Source/core/svg/properties/NewSVGAnimatedProperty.h

Issue 132233010: [SVG] SVGAnimatedRect migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebsaed Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/graphics/SVGImage.cpp ('k') | Source/core/svg/properties/NewSVGListPropertyHelper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/properties/NewSVGAnimatedProperty.h
diff --git a/Source/core/svg/properties/NewSVGAnimatedProperty.h b/Source/core/svg/properties/NewSVGAnimatedProperty.h
index f0ef356552d02d2068e04acfe9e7ab3c9fa48d2f..75774001cd68ef768d53569e874b485b4b9a849d 100644
--- a/Source/core/svg/properties/NewSVGAnimatedProperty.h
+++ b/Source/core/svg/properties/NewSVGAnimatedProperty.h
@@ -137,7 +137,6 @@ public:
TrackExceptionState es;
m_baseValue->setValueAsString(value, es);
- commitChange();
if (es.hadException())
parseError = ParsingAttributeFailedError;
@@ -213,8 +212,11 @@ public:
// Use currentValue() from C++ code.
virtual TearOffType* baseVal()
{
- if (!m_baseValTearOff)
+ if (!m_baseValTearOff) {
m_baseValTearOff = TearOffType::create(this->baseValue(), this->contextElement(), PropertyIsNotAnimVal, this->attributeName());
+ if (this->isReadOnly())
+ m_baseValTearOff->setIsReadOnlyProperty();
+ }
return m_baseValTearOff.get();
}
« no previous file with comments | « Source/core/svg/graphics/SVGImage.cpp ('k') | Source/core/svg/properties/NewSVGListPropertyHelper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698