Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: Source/core/svg/SVGZoomEvent.cpp

Issue 132233010: [SVG] SVGAnimatedRect migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: comment fixes Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 4 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
11 * This library is distributed in the hope that it will be useful, 11 * This library is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of 12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 * Library General Public License for more details. 14 * Library General Public License for more details.
15 * 15 *
16 * You should have received a copy of the GNU Library General Public License 16 * You should have received a copy of the GNU Library General Public License
17 * along with this library; see the file COPYING.LIB. If not, write to 17 * along with this library; see the file COPYING.LIB. If not, write to
18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
19 * Boston, MA 02110-1301, USA. 19 * Boston, MA 02110-1301, USA.
20 */ 20 */
21 21
22 #include "config.h" 22 #include "config.h"
23
haraken 2014/01/16 04:56:43 Nit: This empty line is not needed.
23 #include "core/svg/SVGZoomEvent.h" 24 #include "core/svg/SVGZoomEvent.h"
24 25
25 #include "core/events/ThreadLocalEventNames.h" 26 #include "core/events/ThreadLocalEventNames.h"
27 #include "core/svg/SVGRectTearOff.h"
26 28
27 namespace WebCore { 29 namespace WebCore {
28 30
29 SVGZoomEvent::SVGZoomEvent() 31 SVGZoomEvent::SVGZoomEvent()
30 : m_newScale(0.0f) 32 : m_newScale(0.0f)
31 , m_previousScale(0.0f) 33 , m_previousScale(0.0f)
32 { 34 {
33 ScriptWrappable::init(this); 35 ScriptWrappable::init(this);
34 } 36 }
35 37
36 SVGRect SVGZoomEvent::zoomRectScreen() const 38 PassRefPtr<SVGRectTearOff> SVGZoomEvent::zoomRectScreen() const
37 { 39 {
38 return m_zoomRectScreen; 40 RefPtr<SVGRectTearOff> rectTearOff = SVGRectTearOff::create(SVGRect::create( ), 0, PropertyIsNotAnimVal);
41 rectTearOff->setIsReadOnlyProperty();
haraken 2014/01/16 04:56:43 Just help me understand: Why was previous code wor
kouhei (in TOK) 2014/01/16 05:12:37 Because it was violating the spec. ^p^
42 return rectTearOff.release();
39 } 43 }
40 44
41 float SVGZoomEvent::previousScale() const 45 float SVGZoomEvent::previousScale() const
42 { 46 {
43 return m_previousScale; 47 return m_previousScale;
44 } 48 }
45 49
46 void SVGZoomEvent::setPreviousScale(float scale) 50 void SVGZoomEvent::setPreviousScale(float scale)
47 { 51 {
48 m_previousScale = scale; 52 m_previousScale = scale;
(...skipping 18 matching lines...) Expand all
67 { 71 {
68 return m_newTranslate; 72 return m_newTranslate;
69 } 73 }
70 74
71 const AtomicString& SVGZoomEvent::interfaceName() const 75 const AtomicString& SVGZoomEvent::interfaceName() const
72 { 76 {
73 return EventNames::SVGZoomEvent; 77 return EventNames::SVGZoomEvent;
74 } 78 }
75 79
76 } // namespace WebCore 80 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698