[SVG] SVGAnimatedRect migration to new SVG property impl.

Source/core/svg/SVGViewSpec.h

 /*
  * Copyright (C) 2007 Rob Buis <buis@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 52 matching lines @@
     void setZoomAndPan(unsigned short, ExceptionState&);
     void setZoomAndPanBaseValue(unsigned short zoomAndPan) { m_zoomAndPan = SVGZoomAndPan::parseFromNumber(zoomAndPan); }
 
     SVGElement* contextElement() const { return m_contextElement.get(); }
 
     // Custom non-animated 'transform' property.
     SVGTransformListPropertyTearOff* transform();
     SVGTransformList transformBaseValue() const { return m_transform; }
 
     // Custom animated 'viewBox' property.
-    PassRefPtr<SVGAnimatedRect> viewBox();
-    SVGRect& viewBoxCurrentValue() { return m_viewBox; }
-    SVGRect viewBoxBaseValue() const { return m_viewBox; }
-    void setViewBoxBaseValue(const SVGRect& viewBox) { m_viewBox = viewBox; }
+    SVGAnimatedRect* viewBox() { return m_contextElement ? m_viewBox.get() : 0; }

[haraken, 2014/01/16 04:56:43]

Isn't it a bit dangerous to allow m_viewBox to hold a non-NULL value even though
m_contextElement is cleared? I guess we should clear m_viewBox when
m_contextElement is cleared.

[kouhei (in TOK), 2014/01/16 05:12:37]

Ack. I'll try that.

[kouhei (in TOK), 2014/01/16 06:07:59]

Chatted offline. WeakPtr do not provide "on-clear" callback, so it is a bit
difficult to implement the idea. m_viewBox is owned by SVGViewSpec, so it is
ensured to be alive. The tearoff is also safe as its contextElement is kept
alive from the wrapper.

"return null" was removed as there was no such spec. Modified the LayoutTest
case which tests this.

 
     // Custom animated 'preserveAspectRatio' property.
     PassRefPtr<SVGAnimatedPreserveAspectRatio> preserveAspectRatio();
     SVGPreserveAspectRatio& preserveAspectRatioCurrentValue() { return m_preserveAspectRatio; }
     SVGPreserveAspectRatio preserveAspectRatioBaseValue() const { return m_preserveAspectRatio; }
     void setPreserveAspectRatioBaseValue(const SVGPreserveAspectRatio& preserveAspectRatio) { m_preserveAspectRatio = preserveAspectRatio; }
 
 private:
     explicit SVGViewSpec(WeakPtr<SVGSVGElement>);
 
     static const SVGPropertyInfo* transformPropertyInfo();
-    static const SVGPropertyInfo* viewBoxPropertyInfo();
     static const SVGPropertyInfo* preserveAspectRatioPropertyInfo();
 
     static const AtomicString& transformIdentifier();
-    static const AtomicString& viewBoxIdentifier();
     static const AtomicString& preserveAspectRatioIdentifier();
 
     static PassRefPtr<SVGAnimatedProperty> lookupOrCreateTransformWrapper(SVGViewSpec* contextElement);
-    static PassRefPtr<SVGAnimatedProperty> lookupOrCreateViewBoxWrapper(SVGViewSpec* contextElement);
     static PassRefPtr<SVGAnimatedProperty> lookupOrCreatePreserveAspectRatioWrapper(SVGViewSpec* contextElement);
 
     template<typename CharType>
     bool parseViewSpecInternal(const CharType* ptr, const CharType* end);
 
     WeakPtr<SVGSVGElement> m_contextElement;
 
     SVGZoomAndPanType m_zoomAndPan;
     SVGTransformList m_transform;
-    SVGRect m_viewBox;
+    RefPtr<SVGAnimatedRect> m_viewBox;
     SVGPreserveAspectRatio m_preserveAspectRatio;
     String m_viewTargetString;
 };
 
 } // namespace WebCore
 
 #endif