[SVG] SVGAnimatedRect migration to new SVG property impl.

Source/core/svg/properties/NewSVGAnimatedProperty.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
 G*     * Redistributions in binary form must reproduce the above
@@ skipping 119 matching lines @@
     virtual NewSVGPropertyBase* currentValueBase() OVERRIDE
     {
         return currentValue();
     }
 
     void setBaseValueAsString(const String& value, SVGParsingError& parseError)
     {
         TrackExceptionState es;
 
         m_baseValue->setValueAsString(value, es);
-        commitChange();
 
         if (es.hadException())
             parseError = ParsingAttributeFailedError;
     }
 
     virtual PassRefPtr<NewSVGPropertyBase> createAnimatedValue() OVERRIDE
     {
         return m_baseValue->clone();
     }
 
@@ skipping 52 matching lines @@
     virtual bool needsSynchronizeAttribute() OVERRIDE
     {
         // DOM attribute synchronization is only needed if tear-off is being touched from javascript or the property is being animated.
         // This prevents unnecessary attribute creation on target element.
         return m_baseValTearOff || this->isAnimating();
     }
 
     // SVGAnimated* DOM Spec implementations:
 
     // baseVal()/animVal() are only to be used from SVG DOM implementation.
     // Use currentValue() from C++ code.

[pdr., 2014/01/16 03:25:47]

Should this comment be updated?

[kouhei (in TOK), 2014/01/16 03:42:27]

I think they are fine. currentValue() definition is in the parent class
NewSVGAnimatedPropertyCommon<Property>.

     virtual TearOffType* baseVal()
     {
-        if (!m_baseValTearOff)
+        if (!m_baseValTearOff) {
             m_baseValTearOff = TearOffType::create(this->baseValue(), this->contextElement(), PropertyIsNotAnimVal, this->attributeName());
+            if (this->isReadOnly())
+                m_baseValTearOff->setIsReadOnlyProperty();
+        }
 
         return m_baseValTearOff.get();
     }
 
     TearOffType* animVal()
     {
         if (!m_animValTearOff)
             m_animValTearOff = TearOffType::create(this->currentValue(), this->contextElement(), PropertyIsAnimVal, this->attributeName());
 
         return m_animValTearOff.get();
@@ skipping 84 matching lines @@
         , m_baseValueUpdated(false)
     {
     }
 
     bool m_baseValueUpdated;
 };
 
 }
 
 #endif // NewSVGAnimatedProperty_h