[SVG] SVGAnimatedRect migration to new SVG property impl.

Source/core/svg/SVGFitToViewBox.h

 /*
  * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2010 Rob Buis <buis@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #ifndef SVGFitToViewBox_h
 #define SVGFitToViewBox_h
 
 #include "SVGNames.h"
 #include "core/dom/QualifiedName.h"
+#include "core/svg/SVGDocumentExtensions.h"
+#include "core/svg/SVGParsingError.h"
 #include "core/svg/SVGPreserveAspectRatio.h"
 #include "core/svg/SVGRect.h"
 #include "wtf/HashSet.h"
 
 namespace WebCore {
 
 class AffineTransform;
 class Document;
 
 class SVGFitToViewBox {
 public:
     static AffineTransform viewBoxToViewTransform(const FloatRect& viewBoxRect, const SVGPreserveAspectRatio&, float viewWidth, float viewHeight);
 
     static bool isKnownAttribute(const QualifiedName&);
     static void addSupportedAttributes(HashSet<QualifiedName>&);
 
     template<class SVGElementTarget>
     static bool parseAttribute(SVGElementTarget* target, const QualifiedName& name, const AtomicString& value)
     {
         ASSERT(target);
         if (name == SVGNames::viewBoxAttr) {
-            FloatRect viewBox;
-            bool valueIsValid = !value.isNull() && parseViewBox(&target->document(), value, viewBox);
-            if (valueIsValid)
-                target->setViewBoxBaseValue(viewBox);
-            else
-                target->setViewBoxBaseValue(SVGRect(SVGRect::InvalidSVGRectTag()));
+            SVGParsingError parseError = NoError;
+            target->viewBox()->setBaseValueAsString(value, parseError);
+            target->reportAttributeParsingError(parseError, name, value);
+            if (target->viewBox()->baseValue()->width() < 0.0f) { // check that width is positive
+                target->document().accessSVGExtensions()->reportError("A negative value for ViewBox width is not allowed");
+                target->viewBox()->baseValue()->setInvalid();
+                return true;

[pdr., 2014/01/16 03:25:47]

Should these return false instead of true?

[kouhei (in TOK), 2014/01/16 03:42:27]

This is tricky, but these must return true. This function returns true when it
parsed an attribute with a known name, even if the parse failed.

+            }
+            if (target->viewBox()->baseValue()->height() < 0.0f) { // check that height is positive
+                target->document().accessSVGExtensions()->reportError("A negative value for ViewBox height is not allowed");
+                target->viewBox()->baseValue()->setInvalid();
+                return true;
+            }
             return true;
         }
 
         if (name == SVGNames::preserveAspectRatioAttr) {
             SVGPreserveAspectRatio preserveAspectRatio;
             preserveAspectRatio.parse(value);
             target->setPreserveAspectRatioBaseValue(preserveAspectRatio);
             return true;
         }
 
         return false;
     }
-
-    static bool parseViewBox(Document*, const LChar*& start, const LChar* end, FloatRect& viewBox, bool validate = true);
-    static bool parseViewBox(Document*, const UChar*& start, const UChar* end, FloatRect& viewBox, bool validate = true);
-
-private:
-    static bool parseViewBox(Document*, const String&, FloatRect&);
 };
 
 } // namespace WebCore
 
 #endif // SVGFitToViewBox_h