Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 132233006: Add support for BUG_PREFIX in codereview.settings (Closed)

Created:
6 years, 11 months ago by rmistry
Modified:
6 years, 11 months ago
Reviewers:
iannucci, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, skiabot_google.com
Visibility:
Public.

Description

Add support for BUG_PREFIX in codereview.settings. This change will allow projects other than chromium to specify 'BUG_PREFIX: project_name:' in their codereview.settings file. Currently, the change is created with 'BUG=', entering a project's bug number there will point it to chromium's issue tracker. Adding a project specific prefix will make the links point to the project's issue tracker without the developer having to know about the magic prefix. BUG=skia:1983 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=244801

Patch Set 1 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M git_cl.py View 4 chunks +6 lines, -1 line 0 comments Download
M tests/git_cl_test.py View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmistry
6 years, 11 months ago (2014-01-14 18:57:11 UTC) #1
iannucci
On 2014/01/14 18:57:11, rmistry wrote: For consistency, could you also do this for gcl?
6 years, 11 months ago (2014-01-14 19:37:33 UTC) #2
rmistry
On 2014/01/14 19:37:33, iannucci wrote: > On 2014/01/14 18:57:11, rmistry wrote: > > For consistency, ...
6 years, 11 months ago (2014-01-14 19:56:30 UTC) #3
iannucci
On 2014/01/14 19:56:30, rmistry wrote: > On 2014/01/14 19:37:33, iannucci wrote: > > On 2014/01/14 ...
6 years, 11 months ago (2014-01-14 20:01:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmistry@google.com/132233006/1
6 years, 11 months ago (2014-01-14 21:03:12 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 21:04:51 UTC) #6
Message was sent while issue was closed.
Change committed as 244801

Powered by Google App Engine
This is Rietveld 408576698