Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 132233004: Update remaining core classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, kinuko, tommyw+watchlist_chromium.org
Visibility:
Public.

Description

Update remaining core classes to use OVERRIDE / FINAL when needed Update remaining core classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=eseidel, esprehn BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -62 lines) Patch
M Source/core/fileapi/Blob.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/Blob.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/File.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReader.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/fileapi/FileReaderLoader.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/fileapi/FileReaderSync.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fileapi/Stream.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/mediastream/MediaStreamCenter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/mediastream/RTCDataChannelHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/mediastream/RTCPeerConnectionHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/plugins/DOMMimeType.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/plugins/DOMMimeTypeArray.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/plugins/DOMPlugin.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/plugins/DOMPluginArray.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/plugins/PluginView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/speech/SpeechInput.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/speech/SpeechInputEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/storage/Storage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/storage/StorageEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/testing/InspectorFrontendClientLocal.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/testing/InternalSettings.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/MockPagePopupDriver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/Performance.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/timing/PerformanceMark.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/timing/PerformanceMeasure.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/timing/PerformanceNavigation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/PerformanceResourceTiming.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/timing/PerformanceTiming.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-11 21:13:42 UTC) #1
esprehn
rslgtm To unsubscribe from this group and stop receiving emails from it, send an email ...
6 years, 11 months ago (2014-01-11 21:37:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/132233004/1
6 years, 11 months ago (2014-01-11 21:51:59 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 21:57:39 UTC) #4
Message was sent while issue was closed. 
Change committed as 164937

Powered by Google App Engine
This is Rietveld 408576698