Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1322283002: [WONT COMMIT] Revert of [ServiceWorker] Use appopriate type parameters for WebCallbacks (3/3) (Closed)

Created:
5 years, 3 months ago by nhiroki
Modified:
5 years, 3 months ago
Reviewers:
yhirano
CC:
blink-reviews, dglazkov+blink, serviceworker-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of [ServiceWorker] Use appopriate type parameters for WebCallbacks (3/3) (patchset #1 id:1 of https://codereview.chromium.org/1316293002/ ) Reason for revert: This is a preliminary CL to revert changes for http://crbug.com/523904. Currently these callbacks always receive object ownership, but it's a misinterpretation of the spec and actually Blink cannot assume the embedder always passes object ownership. To fix it, this CL reverts changes dependent on the misinterpretation. Original issue's description: > [ServiceWorker] Use appopriate type parameters for WebCallbacks (3/3) > > > - WebServiceWorkerRegistration* (ownership transferred) > => WebPassOwnPtr<WebServiceWorkerRegistration> > - WebVector<WebServiceWorkerRegistration*> (ownership transferred) > => WebPassOwnPtr<WebVector<WebServiceWorkerRegistration*>> > - WebServiceWorkerError* (ownership transferred) > => const WebServiceWorkerError& > > 1/3: https://codereview.chromium.org/1312343004/ > 2/3: https://codereview.chromium.org/1318953002/ > 3/3: https://codereview.chromium.org/1316293002/ > > BUG=493531, 525340 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201351 TBR=yhirano@chromium.org BUG=493531, 525340, 523904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M public/platform/modules/serviceworker/WebServiceWorkerProvider.h View 1 chunk +28 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
nhiroki
Created Revert of [ServiceWorker] Use appopriate type parameters for WebCallbacks (3/3)
5 years, 3 months ago (2015-09-03 02:22:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322283002/1
5 years, 3 months ago (2015-09-03 02:25:17 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-03 02:25:27 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322283002/1
5 years, 3 months ago (2015-09-03 02:26:03 UTC) #7
nhiroki
Hi Hirano-san, can you take a look at this? I'm really sorry for wasting your ...
5 years, 3 months ago (2015-09-03 02:27:38 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-03 03:06:44 UTC) #10
nhiroki
To be clear, my main purpose is to revert my changes associated with issue 523904. ...
5 years, 3 months ago (2015-09-04 02:21:36 UTC) #11
yhirano
lgtm
5 years, 3 months ago (2015-09-04 02:23:30 UTC) #12
nhiroki
Thank you!
5 years, 3 months ago (2015-09-04 02:30:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322283002/1
5 years, 3 months ago (2015-09-04 03:01:53 UTC) #15
nhiroki
Updated a CL description to clarify my intention more.
5 years, 3 months ago (2015-09-04 03:22:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322283002/1
5 years, 3 months ago (2015-09-04 03:22:32 UTC) #19
nhiroki
5 years, 3 months ago (2015-09-04 07:53:42 UTC) #21
I had offline chat with yhirano@, and we decided to take another approach
instead of reverting these changes. I'll close this and make separate changes.

Powered by Google App Engine
This is Rietveld 408576698