DescriptionRevert of [ServiceWorker] Use appopriate type parameters for WebCallbacks (3/3) (patchset #1 id:1 of https://codereview.chromium.org/1316293002/ )
Reason for revert:
This is a preliminary CL to revert changes for http://crbug.com/523904.
Currently these callbacks always receive object ownership, but it's
a misinterpretation of the spec and actually Blink cannot assume the
embedder always passes object ownership. To fix it, this CL reverts
changes dependent on the misinterpretation.
Original issue's description:
> [ServiceWorker] Use appopriate type parameters for WebCallbacks (3/3)
>
>
> - WebServiceWorkerRegistration* (ownership transferred)
> => WebPassOwnPtr<WebServiceWorkerRegistration>
> - WebVector<WebServiceWorkerRegistration*> (ownership transferred)
> => WebPassOwnPtr<WebVector<WebServiceWorkerRegistration*>>
> - WebServiceWorkerError* (ownership transferred)
> => const WebServiceWorkerError&
>
> 1/3: https://codereview.chromium.org/1312343004/
> 2/3: https://codereview.chromium.org/1318953002/
> 3/3: https://codereview.chromium.org/1316293002/
>
> BUG=493531, 525340
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201351
TBR=yhirano@chromium.org
BUG=493531, 525340, 523904
Patch Set 1 #
Messages
Total messages: 21 (8 generated)
|