ipc: Convert int types from basictypes.h to the ones from stdint.h

ipc: Convert int types from basictypes.h to the ones from stdint.h

Now that the supported toolchain has stdint.h, use the integer types
from this standard header file.

BUG=138542
TEST=ipc_tests
R=tsepez@chromium.org
TBR=sadrul@chromium.org # for ui/

Committed: https://crrev.com/10a5c06e17cca35135ee29556c2c139393f42c43
Cr-Commit-Position: refs/heads/master@{#347457}

[tfarina, 2015-09-02 23:38:12]

I will remove basictypes.h includes in another pass. It will need more work than
this.

PTAL.

[Tom Sepez, 2015-09-03 19:53:09]

lgtm

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_channel_win.h
File ipc/ipc_channel_win.h (right):

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_channel_win.h#newco...
ipc/ipc_channel_win.h:11: #include <queue>
nit: blank line between c and c++ headers.

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_fuzzing_tests.cc
File ipc/ipc_fuzzing_tests.cc (right):

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_fuzzing_tests.cc#ne...
ipc/ipc_fuzzing_tests.cc:7: #include <sstream>
nit: ditto

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_message.h
File ipc/ipc_message.h (right):

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_message.h#newcode9
ipc/ipc_message.h:9: #include <string>
nit: ditto

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_message_utils.h
File ipc/ipc_message_utils.h (right):

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_message_utils.h#new...
ipc/ipc_message_utils.h:9: #include <algorithm>
nit: ditto

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_sync_message.cc
File ipc/ipc_sync_message.cc (right):

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_sync_message.cc#new...
ipc/ipc_sync_message.cc:7: #include "build/build_config.h"
nit: this needs to move down and be alphabetized.

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_test_sink.h
File ipc/ipc_test_sink.h (right):

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_test_sink.h#newcode8
ipc/ipc_test_sink.h:8: #include <stdint.h>
nit: ditto

https://codereview.chromium.org/1322253003/diff/1/ipc/message_filter.h
File ipc/message_filter.h (right):

https://codereview.chromium.org/1322253003/diff/1/ipc/message_filter.h#newcode9
ipc/message_filter.h:9: #include <vector>
nit: ditto

[tfarina, 2015-09-04 14:01:14]

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_channel_win.h
File ipc/ipc_channel_win.h (right):

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_channel_win.h#newco...
ipc/ipc_channel_win.h:11: #include <queue>
On 2015/09/03 19:53:09, Tom Sepez wrote:
> nit: blank line between c and c++ headers.

Done.

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_fuzzing_tests.cc
File ipc/ipc_fuzzing_tests.cc (right):

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_fuzzing_tests.cc#ne...
ipc/ipc_fuzzing_tests.cc:7: #include <sstream>
On 2015/09/03 19:53:09, Tom Sepez wrote:
> nit: ditto

Done.

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_message.h
File ipc/ipc_message.h (right):

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_message.h#newcode9
ipc/ipc_message.h:9: #include <string>
On 2015/09/03 19:53:09, Tom Sepez wrote:
> nit: ditto

Done.

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_message_utils.h
File ipc/ipc_message_utils.h (right):

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_message_utils.h#new...
ipc/ipc_message_utils.h:9: #include <algorithm>
On 2015/09/03 19:53:09, Tom Sepez wrote:
> nit: ditto

Done.

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_sync_message.cc
File ipc/ipc_sync_message.cc (right):

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_sync_message.cc#new...
ipc/ipc_sync_message.cc:7: #include "build/build_config.h"
On 2015/09/03 19:53:09, Tom Sepez wrote:
> nit: this needs to move down and be alphabetized.

Done.

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_test_sink.h
File ipc/ipc_test_sink.h (right):

https://codereview.chromium.org/1322253003/diff/1/ipc/ipc_test_sink.h#newcode8
ipc/ipc_test_sink.h:8: #include <stdint.h>
On 2015/09/03 19:53:09, Tom Sepez wrote:
> nit: ditto

Done.

https://codereview.chromium.org/1322253003/diff/1/ipc/message_filter.h
File ipc/message_filter.h (right):

https://codereview.chromium.org/1322253003/diff/1/ipc/message_filter.h#newcode9
ipc/message_filter.h:9: #include <vector>
On 2015/09/03 19:53:09, Tom Sepez wrote:
> nit: ditto

Done.

[tfarina, 2015-09-04 14:01:25]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-09-04 14:01:25]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1322253003/#ps20001
(title: "Tom review, bot fixes & REBASE")

[commit-bot: I haz the power, 2015-09-04 14:01:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322253003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322253003/20001

[commit-bot: I haz the power, 2015-09-04 14:23:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 14:23:51]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[tfarina, 2015-09-04 15:25:44]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-09-04 15:25:45]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1322253003/#ps40001
(title: "fix cast")

[commit-bot: I haz the power, 2015-09-04 15:26:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322253003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322253003/40001

[commit-bot: I haz the power, 2015-09-04 17:21:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 17:21:44]

Failed to apply patch for ipc/ipc_message.h:
While running git apply --index -3 -p1;
  error: patch failed: ipc/ipc_message.h:220
  Falling back to three-way merge...
  Applied patch to 'ipc/ipc_message.h' with conflicts.
  U ipc/ipc_message.h

Patch:       ipc/ipc_message.h
Index: ipc/ipc_message.h
diff --git a/ipc/ipc_message.h b/ipc/ipc_message.h
index
d0e38afc342218365423056330b0eed5b734d8ba..b689fcb7b808fedc3579b920fcd1124f0df61ad5
100644
--- a/ipc/ipc_message.h
+++ b/ipc/ipc_message.h
@@ -5,6 +5,8 @@
 #ifndef IPC_IPC_MESSAGE_H_
 #define IPC_IPC_MESSAGE_H_
 
+#include <stdint.h>
+
 #include <string>
 
 #include "base/basictypes.h"
@@ -57,7 +59,7 @@ class IPC_EXPORT Message : public base::Pickle {
 
   // Initialize a message with a user-defined type, priority value, and
   // destination WebView ID.
-  Message(int32 routing_id, uint32 type, PriorityValue priority);
+  Message(int32_t routing_id, uint32_t type, PriorityValue priority);
 
   // Initializes a message from a const block of data.  The data is not copied;
   // instead the data is merely referenced by this message.  Only const methods
@@ -127,25 +129,25 @@ class IPC_EXPORT Message : public base::Pickle {
     return dispatch_error_;
   }
 
-  uint32 type() const {
+  uint32_t type() const {
     return header()->type;
   }
 
-  int32 routing_id() const {
+  int32_t routing_id() const {
     return header()->routing;
   }
 
-  void set_routing_id(int32 new_id) {
+  void set_routing_id(int32_t new_id) {
     header()->routing = new_id;
   }
 
-  uint32 flags() const {
+  uint32_t flags() const {
     return header()->flags;
   }
 
   // Sets all the given header values. The message should be empty at this
   // call.
-  void SetHeaderValues(int32 routing, uint32 type, uint32 flags);
+  void SetHeaderValues(int32_t routing, uint32_t type, uint32_t flags);
 
   template<class T, class S, class P>
   static bool Dispatch(const Message* msg, T* obj, S* sender, P* parameter,
@@ -191,11 +193,11 @@ class IPC_EXPORT Message : public base::Pickle {
 #ifdef IPC_MESSAGE_LOG_ENABLED
   // Adds the outgoing time from Time::Now() at the end of the message and sets
   // a bit to indicate that it's been added.
-  void set_sent_time(int64 time);
-  int64 sent_time() const;
+  void set_sent_time(int64_t time);
+  int64_t sent_time() const;
 
-  void set_received_time(int64 time) const;
-  int64 received_time() const { return received_time_; }
+  void set_received_time(int64_t time) const;
+  int64_t received_time() const { return received_time_; }
   void set_output_params(const std::string& op) const { output_params_ = op; }
   const std::string& output_params() const { return output_params_; }
   // The following four functions are needed so we can log sync messages with
@@ -220,18 +222,18 @@ class IPC_EXPORT Message : public base::Pickle {
 
 #pragma pack(push, 4)
   struct Header : base::Pickle::Header {
-    int32 routing;  // ID of the view that this message is destined for
-    uint32 type;    // specifies the user-defined message type
-    uint32 flags;   // specifies control flags for the message
+    int32_t routing;  // ID of the view that this message is destined for
+    uint32_t type;    // specifies the user-defined message type
+    uint32_t flags;   // specifies control flags for the message
 #if USE_ATTACHMENT_BROKER
     // The number of brokered attachments included with this message. The
     // ids of the brokered attachment ids are sent immediately after the
pickled
     // message, before the next pickled message is sent.
-    uint32 num_brokered_attachments;
+    uint32_t num_brokered_attachments;
 #endif
 #if defined(OS_POSIX)
-    uint16 num_fds; // the number of descriptors included with this message
-    uint16 pad;     // explicitly initialize this to appease valgrind
+    uint16_t num_fds; // the number of descriptors included with this message
+    uint16_t pad;     // explicitly initialize this to appease valgrind
 #endif
   };
 #pragma pack(pop)
@@ -268,7 +270,7 @@ class IPC_EXPORT Message : public base::Pickle {
 
 #ifdef IPC_MESSAGE_LOG_ENABLED
   // Used for logging.
-  mutable int64 received_time_;
+  mutable int64_t received_time_;
   mutable std::string output_params_;
   mutable LogData* log_data_;
   mutable bool dont_log_;

[commit-bot: I haz the power, 2015-09-04 17:22:15]

The CQ bit was unchecked by commit-bot@chromium.org

[tfarina, 2015-09-04 17:24:18]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-09-04 17:24:18]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1322253003/#ps60001
(title: "REBASE")

[commit-bot: I haz the power, 2015-09-04 17:24:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322253003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322253003/60001

[commit-bot: I haz the power, 2015-09-04 18:48:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-04 18:48:48]

Patchset 4 (id:??) landed as
https://crrev.com/10a5c06e17cca35135ee29556c2c139393f42c43
Cr-Commit-Position: refs/heads/master@{#347457}