Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1322203005: [turbofan] Handle stack overflow exceptions in JSInliner. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Handle stack overflow exceptions in JSInliner. R=bmeurer@chromium.org BUG=chromium:527364 LOG=n Committed: https://crrev.com/c505907dce7448f4402bf78a2e8bbdb52ee04f7a Cr-Commit-Position: refs/heads/master@{#30651}

Patch Set 1 #

Patch Set 2 : Add regression test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
M src/compiler/js-inlining.cc View 2 chunks +17 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-527364.js View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
Still cleaning up the repro to make a regression test.
5 years, 3 months ago (2015-09-08 17:10:21 UTC) #1
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-08 19:14:46 UTC) #2
Michael Starzinger
Thanks for review. Regression test added. Landing.
5 years, 3 months ago (2015-09-09 09:52:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322203005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322203005/20001
5 years, 3 months ago (2015-09-09 10:22:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-09 10:24:26 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 10:24:44 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c505907dce7448f4402bf78a2e8bbdb52ee04f7a
Cr-Commit-Position: refs/heads/master@{#30651}

Powered by Google App Engine
This is Rietveld 408576698