Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: ios/web/public/ssl_status.h

Issue 1322193003: WKWebView(iOS9): correctly update SSL status for current navigation item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@reland_cert_verification
Patch Set: Addressed David's review comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/public/ssl_status.h
diff --git a/ios/web/public/ssl_status.h b/ios/web/public/ssl_status.h
index 56f3d11fc3d8432ad3336fa06c671c37f30fb2ef..ac373736f51c23a0cd4423c8bd9f064287c75741 100644
--- a/ios/web/public/ssl_status.h
+++ b/ios/web/public/ssl_status.h
@@ -5,6 +5,8 @@
#ifndef IOS_WEB_PUBLIC_SSL_STATUS_H_
#define IOS_WEB_PUBLIC_SSL_STATUS_H_
+#include <string>
+
#include "ios/web/public/security_style.h"
#include "net/cert/cert_status_flags.h"
@@ -33,6 +35,7 @@ struct SSLStatus {
cert_status == status.cert_status &&
security_bits == status.security_bits &&
content_status == status.content_status;
+ // |cert_status_host| is not used for comparisson intentionaly.
davidben 2015/10/16 00:15:20 comparisson -> comparison
Eugene But (OOO till 7-30) 2015/10/16 02:25:35 Done.
}
web::SecurityStyle security_style;
@@ -42,6 +45,11 @@ struct SSLStatus {
int connection_status;
// A combination of the ContentStatusFlags above.
int content_status;
+ // Host which was used for |cert_status| calculation. It is not an actual part
+ // of SSL status, hence it's not taken into account in |Equals| method.
+ // Used to check if |cert_status| is still valid or needs to be recalculated
+ // (f.e. after redirect).
davidben 2015/10/16 00:15:20 f.e. -> e.g. (I'm assuming f.e. is "for example"?
Eugene But (OOO till 7-30) 2015/10/16 02:25:35 Done.
+ std::string cert_status_host;
};
} // namespace web

Powered by Google App Engine
This is Rietveld 408576698