Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1322103006: Moterm: Plumb responses back to the terminal File. (Closed)

Created:
5 years, 3 months ago by viettrungluu
Modified:
5 years, 3 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Moterm: Plumb responses back to the terminal File. Mostly, input and output are completely separate in a terminal, with the part that looks/acts like a terminal emulator just handling output, with the keyboard providing input. However, sometimes the terminal emulator needs to send "input" data, in particular in *response* to escape sequences (sent as output) querying information (such as terminal size). This is needed to make things like "eval `resize`" work. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ead7995d1f053354970558670698ffe9d0fa4f82

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -7 lines) Patch
M apps/moterm/moterm_model.h View 2 chunks +17 lines, -1 line 1 comment Download
M apps/moterm/moterm_model.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M apps/moterm/moterm_model_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M apps/moterm/moterm_view.h View 2 chunks +4 lines, -0 lines 0 comments Download
M apps/moterm/moterm_view.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 3 months ago (2015-09-09 15:47:38 UTC) #1
jamesr
lgtm https://codereview.chromium.org/1322103006/diff/1/apps/moterm/moterm_model.h File apps/moterm/moterm_model.h (right): https://codereview.chromium.org/1322103006/diff/1/apps/moterm/moterm_model.h#newcode114 apps/moterm/moterm_model.h:114: ~Delegate() {} virtual (since you have a vtable ...
5 years, 3 months ago (2015-09-09 16:49:45 UTC) #2
viettrungluu
5 years, 3 months ago (2015-09-09 16:50:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ead7995d1f053354970558670698ffe9d0fa4f82 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698