Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1322103005: PPC: On a call to Array(), we patched a call ic. This CL makes do with a single dispatcher which in… (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: On a call to Array(), we patched a call ic. This CL makes do with a single dispatcher which inlines the special handling for the Array() call case, loading the allocation site found in the vector and calling the array constructor stub appropriately. Port ba7b64139886ab7987406a92bf0e801b807c9fe4 R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/50fa1e50ecd98e1c6394ae71c7a36c6fa825c215 Cr-Commit-Position: refs/heads/master@{#30661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -37 lines) Patch
M src/ppc/code-stubs-ppc.cc View 4 chunks +21 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 3 months ago (2015-09-09 14:53:09 UTC) #1
dstence
lgtm
5 years, 3 months ago (2015-09-09 15:30:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322103005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322103005/1
5 years, 3 months ago (2015-09-09 15:33:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 15:59:00 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 15:59:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50fa1e50ecd98e1c6394ae71c7a36c6fa825c215
Cr-Commit-Position: refs/heads/master@{#30661}

Powered by Google App Engine
This is Rietveld 408576698