Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 1322063002: Run HTMLSourceTracker hooks only when XSSAuditor is enabled (Closed)

Created:
5 years, 3 months ago by kouhei (in TOK)
Modified:
5 years, 3 months ago
Reviewers:
Yoav Weiss
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, kinuko+watch
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Run HTMLSourceTracker hooks only when XSSAuditor is enabled HTMLSourceTracker enables XSSAuditor to examine corresponding raw HTML source to check if it contains XSS attempts. HTMLSourceTracker is currently very slow involving full copy of pending input SegmentedString. Before this CL, HTMLSourceTracker was invoked on every HTMLToken regardless of XSSAuditor is enabled. This CL avoids running HTMLSourceTracker when XSSAuditor is not enabled. BUG=520296 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M Source/core/html/parser/BackgroundHTMLParser.cpp View 2 chunks +7 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/html/parser/XSSAuditor.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kouhei (in TOK)
5 years, 3 months ago (2015-08-31 23:54:44 UTC) #2
Yoav Weiss
On 2015/08/31 23:54:44, kouhei wrote: LGTM
5 years, 3 months ago (2015-09-01 07:18:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322063002/1
5 years, 3 months ago (2015-09-01 07:19:48 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 07:43:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201530

Powered by Google App Engine
This is Rietveld 408576698