Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: Source/web/WebDevToolsAgentImpl.h

Issue 1322053002: Devtools: Move inspectMode logic from InspectorDomAgent to InspectorOverlayImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« Source/web/InspectorOverlayImpl.cpp ('K') | « Source/web/InspectorOverlayImpl.cpp ('k') | Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 , private WebThread::TaskObserver { 76 , private WebThread::TaskObserver {
77 public: 77 public:
78 static PassOwnPtrWillBeRawPtr<WebDevToolsAgentImpl> create(WebLocalFrameImpl *, WebDevToolsAgentClient*); 78 static PassOwnPtrWillBeRawPtr<WebDevToolsAgentImpl> create(WebLocalFrameImpl *, WebDevToolsAgentClient*);
79 ~WebDevToolsAgentImpl() override; 79 ~WebDevToolsAgentImpl() override;
80 void dispose(); 80 void dispose();
81 DECLARE_VIRTUAL_TRACE(); 81 DECLARE_VIRTUAL_TRACE();
82 82
83 void willBeDestroyed(); 83 void willBeDestroyed();
84 WebDevToolsAgentClient* client() { return m_client; } 84 WebDevToolsAgentClient* client() { return m_client; }
85 InspectorOverlayImpl* overlay() const { return m_overlay.get(); } 85 InspectorOverlayImpl* overlay() const { return m_overlay.get(); }
86 bool handleInputEvent(const WebInputEvent&);
87 void flushPendingProtocolNotifications(); 86 void flushPendingProtocolNotifications();
88 void dispatchMessageFromFrontend(const String& message); 87 void dispatchMessageFromFrontend(const String& message);
89 void registerAgent(PassOwnPtrWillBeRawPtr<InspectorAgent>); 88 void registerAgent(PassOwnPtrWillBeRawPtr<InspectorAgent>);
90 static void webViewImplClosed(WebViewImpl*); 89 static void webViewImplClosed(WebViewImpl*);
91 static void webFrameWidgetImplClosed(WebFrameWidgetImpl*); 90 static void webFrameWidgetImplClosed(WebFrameWidgetImpl*);
92 91
93 // Instrumentation from web/ layer. 92 // Instrumentation from web/ layer.
94 void didCommitLoadForLocalFrame(LocalFrame*); 93 void didCommitLoadForLocalFrame(LocalFrame*);
95 bool screencastEnabled(); 94 bool screencastEnabled();
96 void willAddPageOverlay(const GraphicsLayer*); 95 void willAddPageOverlay(const GraphicsLayer*);
(...skipping 25 matching lines...) Expand all
122 // InspectorFrontendChannel implementation. 121 // InspectorFrontendChannel implementation.
123 void sendProtocolResponse(int callId, PassRefPtr<JSONObject> message) overri de; 122 void sendProtocolResponse(int callId, PassRefPtr<JSONObject> message) overri de;
124 void sendProtocolNotification(PassRefPtr<JSONObject> message) override; 123 void sendProtocolNotification(PassRefPtr<JSONObject> message) override;
125 void flush() override; 124 void flush() override;
126 125
127 // WebThread::TaskObserver implementation. 126 // WebThread::TaskObserver implementation.
128 void willProcessTask() override; 127 void willProcessTask() override;
129 void didProcessTask() override; 128 void didProcessTask() override;
130 129
131 void initializeDeferredAgents(); 130 void initializeDeferredAgents();
132 bool handleGestureEvent(LocalFrame*, const PlatformGestureEvent&);
133 bool handleMouseEvent(LocalFrame*, const PlatformMouseEvent&);
134 bool handleTouchEvent(LocalFrame*, const PlatformTouchEvent&);
135 131
136 WebDevToolsAgentClient* m_client; 132 WebDevToolsAgentClient* m_client;
137 RawPtrWillBeMember<WebLocalFrameImpl> m_webLocalFrameImpl; 133 RawPtrWillBeMember<WebLocalFrameImpl> m_webLocalFrameImpl;
138 bool m_attached; 134 bool m_attached;
139 #if ENABLE(ASSERT) 135 #if ENABLE(ASSERT)
140 bool m_hasBeenDisposed; 136 bool m_hasBeenDisposed;
141 #endif 137 #endif
142 138
143 RefPtrWillBeMember<InstrumentingAgents> m_instrumentingAgents; 139 RefPtrWillBeMember<InstrumentingAgents> m_instrumentingAgents;
144 OwnPtrWillBeMember<InjectedScriptManager> m_injectedScriptManager; 140 OwnPtrWillBeMember<InjectedScriptManager> m_injectedScriptManager;
(...skipping 20 matching lines...) Expand all
165 typedef Vector<RefPtr<JSONObject>> NotificationQueue; 161 typedef Vector<RefPtr<JSONObject>> NotificationQueue;
166 NotificationQueue m_notificationQueue; 162 NotificationQueue m_notificationQueue;
167 String m_stateCookie; 163 String m_stateCookie;
168 164
169 friend class DebuggerTask; 165 friend class DebuggerTask;
170 }; 166 };
171 167
172 } // namespace blink 168 } // namespace blink
173 169
174 #endif 170 #endif
OLDNEW
« Source/web/InspectorOverlayImpl.cpp ('K') | « Source/web/InspectorOverlayImpl.cpp ('k') | Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698