Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1322033003: Stop compiling dead download infobar code on desktop Chrome (Closed)

Created:
5 years, 3 months ago by Evan Stade
Modified:
5 years, 3 months ago
Reviewers:
felt, Paweł Hajdan Jr.
CC:
asanka, benjhayden+dwatch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop compiling dead download infobar code on desktop Chrome BUG=502515 Committed: https://crrev.com/2ac889ea363a69367bd5f7e06da722ab1d13800b Cr-Commit-Position: refs/heads/master@{#346933}

Patch Set 1 #

Patch Set 2 : fix unit tests (only run them on android) #

Patch Set 3 : fix browser test, unit test #

Patch Set 4 : checkpoint #

Patch Set 5 : revert accidental changes #

Patch Set 6 : git cl try #

Patch Set 7 : fix gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -40 lines) Patch
M chrome/browser/download/OWNERS View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 2 4 chunks +5 lines, -14 lines 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 3 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/download/download_request_limiter_unittest.cc View 1 2 9 chunks +26 lines, -10 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 28 (12 generated)
Evan Stade
5 years, 3 months ago (2015-08-31 22:37:13 UTC) #1
Evan Stade
5 years, 3 months ago (2015-08-31 22:37:21 UTC) #3
felt
lgtm
5 years, 3 months ago (2015-08-31 22:39:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322033003/1
5 years, 3 months ago (2015-08-31 22:51:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/94943)
5 years, 3 months ago (2015-08-31 23:02:12 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322033003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322033003/20001
5 years, 3 months ago (2015-08-31 23:46:27 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/63082) linux_chromium_gn_rel on ...
5 years, 3 months ago (2015-09-01 00:03:27 UTC) #12
Evan Stade
+ahendrickson for OWNERS
5 years, 3 months ago (2015-09-01 18:22:06 UTC) #14
Evan Stade
-ahendrickson, +benjhayden
5 years, 3 months ago (2015-09-01 18:23:58 UTC) #16
Evan Stade
benjhayden apparently OOO next up, phajdan.jr
5 years, 3 months ago (2015-09-01 21:14:47 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322033003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322033003/120001
5 years, 3 months ago (2015-09-01 22:21:22 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-01 22:51:32 UTC) #22
Paweł Hajdan Jr.
LGTM
5 years, 3 months ago (2015-09-02 10:37:48 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322033003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322033003/120001
5 years, 3 months ago (2015-09-02 16:23:19 UTC) #26
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 3 months ago (2015-09-02 16:28:27 UTC) #27
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 16:29:16 UTC) #28
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/2ac889ea363a69367bd5f7e06da722ab1d13800b
Cr-Commit-Position: refs/heads/master@{#346933}

Powered by Google App Engine
This is Rietveld 408576698