Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 132203012: Make Custom Element registration context creation explicit. (Closed)

Created:
6 years, 10 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 10 months ago
Reviewers:
dglazkov
CC:
blink-reviews, gavinp+loader_chromium.org, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Make Custom Element registration context creation explicit. This brings the implementation into line with the spec, which specifies when a document *does* get a new registration context, or shares an existing one, instead of applying a heuristic based on document type. See <http://w3c.github.io/webcomponents/spec/custom/#creating-and-passing-registries>; BUG=339431 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166359

Patch Set 1 #

Patch Set 2 : Nicer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -29 lines) Patch
M LayoutTests/fast/dom/custom/registration-context-isolation.html View 1 chunk +37 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-isolation-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-sharing.html View 4 chunks +8 lines, -23 lines 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-sharing-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
A + LayoutTests/http/tests/custom/resources/blank.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/http/tests/custom/xhr-response-does-not-have-registry.html View 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/custom/xhr-response-does-not-have-registry-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentInit.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/DocumentInit.cpp View 1 4 chunks +13 lines, -4 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
dominicc (has gone to gerrit)
6 years, 10 months ago (2014-01-31 07:54:25 UTC) #1
dominicc (has gone to gerrit)
PTAL
6 years, 10 months ago (2014-02-03 00:02:01 UTC) #2
dglazkov
lgtm!
6 years, 10 months ago (2014-02-03 17:30:23 UTC) #3
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 10 months ago (2014-02-03 23:17:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/132203012/20001
6 years, 10 months ago (2014-02-03 23:18:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 23:33:56 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout&number=18795
6 years, 10 months ago (2014-02-03 23:33:57 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:34:00 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:34:04 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:34:05 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:34:05 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:36:10 UTC) #12
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 10 months ago (2014-02-04 00:57:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/132203012/20001
6 years, 10 months ago (2014-02-04 00:58:01 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 07:05:26 UTC) #15
Message was sent while issue was closed. 
Change committed as 166359

Powered by Google App Engine
This is Rietveld 408576698