Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 132203009: Avoid hacking on the case of a typename. (Closed)

Created:
6 years, 11 months ago by Jeffrey Yasskin
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Avoid hacking on the case of a typename. This allows me to mention the ImageData type without it being transformed to "imagedata". It may have some side-effects where we've been sloppy with typenames elsewhere, but let me know if you see any, and I'll fix them. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244332

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/common/extensions/docs/server2/api_data_source.py View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Jeffrey Yasskin
I don't see anywhere in the existing docs that this affects (my use is from ...
6 years, 11 months ago (2014-01-10 01:14:28 UTC) #1
not at google - send to devlin
lgtm, if this does break anything perhaps the casing can be handled by CSS anyway.
6 years, 11 months ago (2014-01-10 23:08:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/132203009/1
6 years, 11 months ago (2014-01-11 00:21:36 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 03:21:53 UTC) #4
Message was sent while issue was closed.
Change committed as 244332

Powered by Google App Engine
This is Rietveld 408576698