Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 132203008: Fix PrerenderBrowserTest.PrerenderPageRemovesPending. (Closed)

Created:
6 years, 11 months ago by davidben
Modified:
6 years, 11 months ago
Reviewers:
mmenke
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org
Visibility:
Public.

Description

Fix PrerenderBrowserTest.PrerenderPageRemovesPending. AddEventHandlersToLinkElement was misspelled, so it wasn't actually counting prerender events. BUG=none TEST=PrerenderBrowserTest.PrerenderPageRemovesPending Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/data/prerender/prerender_page_removes_pending.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
davidben
6 years, 11 months ago (2014-01-09 22:03:14 UTC) #1
mmenke
Wow....That's bad. I think I even reviewed the CL that added that. LGTM!
6 years, 11 months ago (2014-01-09 22:24:28 UTC) #2
mmenke
On 2014/01/09 22:24:28, mmenke wrote: > Wow....That's bad. I think I even reviewed the CL ...
6 years, 11 months ago (2014-01-09 22:26:02 UTC) #3
davidben
On 2014/01/09 22:26:02, mmenke wrote: > On 2014/01/09 22:24:28, mmenke wrote: > > Wow....That's bad. ...
6 years, 11 months ago (2014-01-09 22:28:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/132203008/1
6 years, 11 months ago (2014-01-09 22:41:46 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=111351
6 years, 11 months ago (2014-01-10 00:35:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/132203008/1
6 years, 11 months ago (2014-01-10 02:19:11 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 03:37:36 UTC) #8
Message was sent while issue was closed.
Change committed as 244073

Powered by Google App Engine
This is Rietveld 408576698