Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 132203007: First set of changes to remove ENABLE_ORIENTATION_EVENT compile time flag. (Closed)

Created:
6 years, 11 months ago by maheshkk
Modified:
6 years, 11 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

First set of changes to remove ENABLE_ORIENTATION_EVENT compile time flag. Adding OrientationEvent runtime flag and the equivalent WebRuntimeFeature API. BUG=181136, 331337 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164842

Patch Set 1 #

Total comments: 1

Patch Set 2 : Ah! Missing class name. #

Patch Set 3 : Fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 1 chunk +10 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
maheshkk
Adding only the runtime flag without state to it. CL for chrome will follow when ...
6 years, 11 months ago (2014-01-09 21:30:18 UTC) #1
eseidel
https://codereview.chromium.org/132203007/diff/1/Source/web/WebRuntimeFeatures.cpp File Source/web/WebRuntimeFeatures.cpp (right): https://codereview.chromium.org/132203007/diff/1/Source/web/WebRuntimeFeatures.cpp#newcode283 Source/web/WebRuntimeFeatures.cpp:283: void enableOrientationEvent(bool enable) This won't work. You're missing WebRuntimeFeatures::
6 years, 11 months ago (2014-01-09 21:47:52 UTC) #2
maheshkk
On 2014/01/09 21:47:52, eseidel wrote: > https://codereview.chromium.org/132203007/diff/1/Source/web/WebRuntimeFeatures.cpp > File Source/web/WebRuntimeFeatures.cpp (right): > > https://codereview.chromium.org/132203007/diff/1/Source/web/WebRuntimeFeatures.cpp#newcode283 > ...
6 years, 11 months ago (2014-01-09 21:53:51 UTC) #3
eseidel
lgtm
6 years, 11 months ago (2014-01-09 22:13:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/132203007/60001
6 years, 11 months ago (2014-01-09 22:13:43 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, wtf_unittests ...
6 years, 11 months ago (2014-01-09 23:01:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/132203007/220001
6 years, 11 months ago (2014-01-09 23:08:01 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 06:13:34 UTC) #8
Message was sent while issue was closed. 
Change committed as 164842

Powered by Google App Engine
This is Rietveld 408576698