Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1322023002: Minor cleanup in GrTessellatingPathRenderer. (Closed)

Created:
5 years, 3 months ago by senorblanco
Modified:
5 years, 3 months ago
Reviewers:
bsalomon, Stephen White
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Minor cleanup in GrTessellatingPathRenderer. Vertex counts are always exact, so don't bother handling the case where they're different. Just assert. Rename variables to reflect. BUG=skia: Committed: https://skia.googlesource.com/skia/+/9389b871c3b0f06bb34626cf9bdbfe0c93779327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M src/gpu/GrTessellatingPathRenderer.cpp View 7 chunks +19 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Stephen White
Brian: PTAL. Thanks!
5 years, 3 months ago (2015-08-31 19:13:17 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322023002/1
5 years, 3 months ago (2015-08-31 19:13:34 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-31 19:19:06 UTC) #7
bsalomon
On 2015/08/31 19:19:06, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 3 months ago (2015-08-31 19:41:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322023002/1
5 years, 3 months ago (2015-08-31 19:41:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9389b871c3b0f06bb34626cf9bdbfe0c93779327
5 years, 3 months ago (2015-08-31 19:42:26 UTC) #11
Stephen White
5 years, 3 months ago (2015-09-02 15:50:41 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1321723006/ by senorblanco@chromium.org.

The reason for reverting is: Patch is incorrect -- floating point errors can
cause zero-area monotone polys to be skipped, resulting in a smaller vertex
count than estimated.

Reproduce as follows: 

out/Debug/SampleApp --slide Fuzzer --msaa 4

switch to GPU mode. Result:

../../src/gpu/batches/GrTessellatingPathRenderer.cpp:1500: failed assertion
"static_cast<int>(end - verts) == vertexCount".

Powered by Google App Engine
This is Rietveld 408576698