Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1322003002: Drop region parameter to Unbounded, as it can be done without. (Closed)

Created:
5 years, 3 months ago by bradn
Modified:
5 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Drop region parameter to Unbounded, as it can be done without. Unbounded is defined in terms of None any Any, which don't require an explicit zone. Switching Unbounded to be the same. BUG= None TEST= trybots R= titzer@chromium.org LOG=N Committed: https://crrev.com/204b6ff066eb735fe183783dc5b6d7ca14777867 Cr-Commit-Position: refs/heads/master@{#30482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -28 lines) Patch
M src/ast.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/typer.cc View 11 chunks +16 lines, -16 lines 0 comments Download
M src/effects.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/types.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/typing-reset.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/typing-reset.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/expression-type-collector-macros.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
bradn
5 years, 3 months ago (2015-08-31 16:41:36 UTC) #1
titzer
lgtm
5 years, 3 months ago (2015-08-31 17:35:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322003002/1
5 years, 3 months ago (2015-08-31 17:35:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 17:37:03 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 17:37:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/204b6ff066eb735fe183783dc5b6d7ca14777867
Cr-Commit-Position: refs/heads/master@{#30482}

Powered by Google App Engine
This is Rietveld 408576698