Issue 1321993005: New SELECT popup: Delay change event dispatching when an option is selected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1321993005: New SELECT popup: Delay change event dispatching when an option is selected. (Closed)

Created:
5 years, 3 months ago by tkent

Modified:
5 years, 3 months ago

Reviewers:
keishi

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

New SELECT popup: Delay change event dispatching when an option is selected. This is a speculative fix for crbug.com/515899. If a JavaScript dialog is opened while a SELECT popup is shown, and the SELECT popup is hidden before the dialog is hidden, window focus is not correctly restored. So, we guess delaying change events solves the problem. BUG=515899 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201952

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	Source/core/events/ScopedEventQueue.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	Source/web/PopupMenuImpl.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321993005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321993005/1

5 years, 3 months ago (2015-09-09 04:29:38 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-09 04:34:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201952

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages