Revert of Avoid sync IPCs for firstRectForCharacterRange/attributedSubstringForProposedRange.

Revert of Avoid sync IPCs for firstRectForCharacterRange/attributedSubstringForProposedRange. (patchset #9 id:160001 of https://codereview.chromium.org/1301173002/ )

Reason for revert:
Caused regression: crbug.com/526611.

Need to support asynchronous "Look Up in Dictionary" with attributed string by context menu.

Original issue's description:
> Avoid sync IPCs for firstRectForCharacterRange/attributedSubstringForProposedRange.
>
> For firstRectForCharacterRange, always uses the cached rect. And it will make
> IME get the wrong/old rect to position its suggestion window.
> For attributedSubstringForProposedRange, always uses composition or
> selection text. And it will drop the string format (fonts/color/etc.) information.
>
> This cl is a trade-off between making IME behave properly and avoid freezing UI.
>
> I try to make this change as small as possible so that it can be easily
> rolled back for potential regressions.
> The changes of cleanning up the IPC defitions and code in
> TextInputClientMac will be done in a separated cl.
>
> BUG=121917, 473850
> TEST=Verified bug not repro on local build.
>
> Committed: https://crrev.com/bc6b777b385ff691d69479691cd259215cb32e4f
> Cr-Commit-Position: refs/heads/master@{#345828}

TBR=asvitkine@chromium.org,yukawa@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=121917, 473850
Committed: https://crrev.com/64883bfcc6088e2cc7b447aa419d972d8346884f
Cr-Commit-Position: refs/heads/master@{#346386}

[Shu Chen, 2015-08-31 15:09:18]

Created Revert of Avoid sync IPCs for
firstRectForCharacterRange/attributedSubstringForProposedRange.

[commit-bot: I haz the power, 2015-08-31 15:09:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321983003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321983003/1

[commit-bot: I haz the power, 2015-08-31 15:10:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 15:10:12]

Failed to apply patch for
content/browser/renderer_host/render_widget_host_view_mac.mm:
While running git apply --index -3 -p1;
  error: patch failed:
content/browser/renderer_host/render_widget_host_view_mac.mm:1446
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: content/browser/renderer_host/render_widget_host_view_mac.mm: patch
does not apply

Patch:       content/browser/renderer_host/render_widget_host_view_mac.mm
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm
b/content/browser/renderer_host/render_widget_host_view_mac.mm
index
1dfc3d4e5abcfafa04c380f4e2022ea271d79893..66f1c31650f7799701f8aba763b515e7c340aaeb
100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -1225,7 +1225,6 @@
     const ViewHostMsg_SelectionBounds_Params& params) {
   if (params.anchor_rect == params.focus_rect)
     caret_rect_ = params.anchor_rect;
-  first_selection_rect_ = params.anchor_rect;
 }
 
 void RenderWidgetHostViewMac::SetShowingContextMenu(bool showing) {
@@ -1446,25 +1445,16 @@
   TRACE_EVENT0("browser",
                "RenderWidgetHostViewMac::GetFirstRectForCharacterRange");
 
-  const gfx::Range requested_range(range);
   // If requested range is same as caret location, we can just return it.
-  if (selection_range_.is_empty() && requested_range == selection_range_) {
+  if (selection_range_.is_empty() && gfx::Range(range) == selection_range_) {
     if (actual_range)
       *actual_range = range;
     *rect = NSRectFromCGRect(caret_rect_.ToCGRect());
     return true;
   }
 
-  if (composition_range_.is_empty()) {
-    if (!selection_range_.Contains(requested_range))
-      return false;
-    *actual_range = selection_range_.ToNSRange();
-    *rect = NSRectFromCGRect(first_selection_rect_.ToCGRect());
-    return true;
-  }
-
   const gfx::Range request_range_in_composition =
-      ConvertCharacterRangeToCompositionRange(requested_range);
+      ConvertCharacterRangeToCompositionRange(gfx::Range(range));
   if (request_range_in_composition == gfx::Range::InvalidRange())
     return false;
 
@@ -2897,36 +2887,10 @@
   // TODO(thakis): Pipe |actualRange| through TextInputClientMac machinery.
   if (actualRange)
     *actualRange = range;
-
-  const gfx::Range requested_range(range);
-  if (requested_range.is_reversed())
-    return nil;
-
-  gfx::Range expected_range;
-  const base::string16* expected_text;
-
-  if (!renderWidgetHostView_->composition_range().is_empty()) {
-    expected_text = &markedText_;
-    expected_range = renderWidgetHostView_->composition_range();
-  } else {
-    expected_text = &renderWidgetHostView_->selection_text();
-    size_t offset = renderWidgetHostView_->selection_text_offset();
-    expected_range = gfx::Range(offset, offset + expected_text->size());
-  }
-
-  if (!expected_range.Contains(requested_range))
-    return nil;
-
-  // Gets the raw bytes to avoid unnecessary string copies for generating
-  // NSString.
-  const base::char16* bytes =
-      &(*expected_text)[requested_range.start() - expected_range.start()];
-  NSUInteger bytes_len = requested_range.length() * sizeof(base::char16);
-  base::scoped_nsobject<NSString> ns_string(
-      [[NSString alloc] initWithBytes:bytes
-                               length:bytes_len
-                             encoding:NSUTF16StringEncoding]);
-  return [[[NSAttributedString alloc] initWithString:ns_string] autorelease];
+  NSAttributedString* str =
+      TextInputClientMac::GetInstance()->GetAttributedSubstringFromRange(
+          renderWidgetHostView_->render_widget_host_, range);
+  return str;
 }
 
 - (NSInteger)conversationIdentifier {

[commit-bot: I haz the power, 2015-08-31 15:10:37]

The CQ bit was unchecked by commit-bot@chromium.org

[Shu Chen, 2015-08-31 15:12:53]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2015-08-31 15:12:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321983003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321983003/1

[commit-bot: I haz the power, 2015-08-31 15:13:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-31 15:14:13]

Patchset 1 (id:??) landed as
https://crrev.com/64883bfcc6088e2cc7b447aa419d972d8346884f
Cr-Commit-Position: refs/heads/master@{#346386}