Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1321943004: Make gold plugin download more robust. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, pcc1
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make gold plugin download more robust. BUG=chromium:515782 LOG=n Committed: https://crrev.com/d9fd711a6130005cc704b313187fcc6eaee6f687 Cr-Commit-Position: refs/heads/master@{#30583}

Patch Set 1 #

Patch Set 2 : Meh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/download_gold_plugin.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321943004/1
5 years, 3 months ago (2015-09-04 08:19:55 UTC) #3
Michael Achenbach
PTAL
5 years, 3 months ago (2015-09-04 08:19:56 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/7569) v8_linux64_asan_rel on ...
5 years, 3 months ago (2015-09-04 08:20:37 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321943004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321943004/20001
5 years, 3 months ago (2015-09-04 08:21:45 UTC) #8
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-04 08:22:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321943004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321943004/20001
5 years, 3 months ago (2015-09-04 08:26:00 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-04 08:52:17 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 08:52:40 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d9fd711a6130005cc704b313187fcc6eaee6f687
Cr-Commit-Position: refs/heads/master@{#30583}

Powered by Google App Engine
This is Rietveld 408576698