Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13219005: Replace string16 with base::string16 in src/webkit (Closed)

Created:
7 years, 9 months ago by brettw
Modified:
7 years, 8 months ago
Reviewers:
jamesr
CC:
chromium-reviews, michaeln, tzik+watch_chromium.org, rpetterson, rouslan+spellwatch_chromium.org, darin-cc_chromium.org, sail+watch_chromium.org, Paweł Hajdan Jr., groby+spellwatch_chromium.org, cc-bugs_chromium.org, kinuko+watch
Visibility:
Public.

Description

Replace string16 with base::string16 in src/webkit BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191421

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+807 lines, -755 lines) Patch
M webkit/appcache/manifest_parser.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M webkit/compositor_bindings/web_layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/database/database_connections.h View 3 chunks +22 lines, -22 lines 0 comments Download
M webkit/database/database_connections.cc View 6 chunks +21 lines, -19 lines 0 comments Download
M webkit/database/database_connections_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M webkit/database/database_quota_client.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/database/database_quota_client_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webkit/database/database_tracker.h View 11 chunks +71 lines, -67 lines 1 comment Download
M webkit/database/database_tracker.cc View 29 chunks +73 lines, -64 lines 0 comments Download
M webkit/database/database_tracker_unittest.cc View 10 chunks +45 lines, -42 lines 0 comments Download
M webkit/database/database_util.h View 2 chunks +11 lines, -10 lines 0 comments Download
M webkit/database/database_util.cc View 5 chunks +20 lines, -18 lines 0 comments Download
M webkit/database/database_util_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/database/databases_table.h View 3 chunks +13 lines, -13 lines 0 comments Download
M webkit/database/databases_table.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M webkit/database/databases_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/database/vfs_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/dom_storage/dom_storage_area.h View 2 chunks +5 lines, -5 lines 1 comment Download
M webkit/dom_storage/dom_storage_area.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M webkit/dom_storage/dom_storage_area_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M webkit/dom_storage/dom_storage_cached_area.h View 3 chunks +10 lines, -8 lines 0 comments Download
M webkit/dom_storage/dom_storage_cached_area.cc View 5 chunks +14 lines, -11 lines 0 comments Download
M webkit/dom_storage/dom_storage_cached_area_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M webkit/dom_storage/dom_storage_context.h View 2 chunks +8 lines, -8 lines 0 comments Download
M webkit/dom_storage/dom_storage_context.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/dom_storage/dom_storage_context_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/dom_storage/dom_storage_database.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/dom_storage/dom_storage_database.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/dom_storage/dom_storage_database_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M webkit/dom_storage/dom_storage_host.h View 2 chunks +7 lines, -7 lines 0 comments Download
M webkit/dom_storage/dom_storage_host.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/dom_storage/dom_storage_map.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/dom_storage/dom_storage_map.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webkit/dom_storage/dom_storage_map_unittest.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M webkit/dom_storage/dom_storage_proxy.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/dom_storage/dom_storage_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/dom_storage/session_storage_database.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/dom_storage/session_storage_database_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/clipboard_client.h View 2 chunks +6 lines, -5 lines 0 comments Download
M webkit/glue/dom_operations.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/dom_operations.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/ftp_directory_listing_response_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/glue_serialize_unittest.cc View 3 chunks +14 lines, -10 lines 0 comments Download
M webkit/glue/web_io_operators.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webclipboard_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/glue/webdropdata.h View 5 chunks +10 lines, -10 lines 0 comments Download
M webkit/glue/webdropdata.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/glue/webdropdata_win.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M webkit/glue/webkit_glue.h View 3 chunks +10 lines, -8 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M webkit/glue/webkit_glue_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webmenuitem.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/webpreferences.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webpreferences.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M webkit/mocks/mock_webhyphenator.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_constants_win.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_instance.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_lib_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_win.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M webkit/plugins/npapi/plugin_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.h View 4 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_mac.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_win.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M webkit/plugins/npapi/webplugin_ime_win.h View 5 chunks +7 lines, -7 lines 0 comments Download
M webkit/plugins/npapi/webplugin_ime_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/webplugin_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/event_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 4 chunks +11 lines, -11 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 8 chunks +19 lines, -17 lines 0 comments Download
M webkit/plugins/webplugininfo.h View 2 chunks +9 lines, -9 lines 0 comments Download
M webkit/plugins/webplugininfo.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/support/platform_support_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/support/platform_support_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/support/platform_support_mac.mm View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/support/platform_support_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/support/simple_database_system.h View 3 chunks +24 lines, -23 lines 0 comments Download
M webkit/support/simple_database_system.cc View 16 chunks +33 lines, -27 lines 0 comments Download
M webkit/support/test_webkit_platform_support.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/mock_spellcheck.h View 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/mock_spellcheck.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M webkit/tools/test_shell/mock_webclipboard_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/mock_webclipboard_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/simple_clipboard_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/simple_clipboard_impl.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M webkit/tools/test_shell/simple_dom_storage_system.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/simple_dom_storage_system.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_navigation_controller.h View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_navigation_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_shell_gtk.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell_mac.mm View 4 chunks +6 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
TBR=jamesr
7 years, 9 months ago (2013-03-28 20:51:23 UTC) #1
jamesr
https://codereview.chromium.org/13219005/diff/1/webkit/database/database_tracker.h File webkit/database/database_tracker.h (right): https://codereview.chromium.org/13219005/diff/1/webkit/database/database_tracker.h#newcode18 webkit/database/database_tracker.h:18: #include "base/string16.h.h" doubt this is intentional
7 years, 9 months ago (2013-03-28 21:00:49 UTC) #2
jamesr
https://codereview.chromium.org/13219005/diff/1/webkit/dom_storage/dom_storage_area.h File webkit/dom_storage/dom_storage_area.h (right): https://codereview.chromium.org/13219005/diff/1/webkit/dom_storage/dom_storage_area.h#newcode12 webkit/dom_storage/dom_storage_area.h:12: #include "base/nullable_base::string16.h" this also looks wrong
7 years, 9 months ago (2013-03-28 21:02:59 UTC) #3
jamesr
lgtm with fixed #includes
7 years, 9 months ago (2013-03-28 21:04:19 UTC) #4
dcheng
On 2013/03/28 21:02:59, jamesr wrote: > https://codereview.chromium.org/13219005/diff/1/webkit/dom_storage/dom_storage_area.h > File webkit/dom_storage/dom_storage_area.h (right): > > https://codereview.chromium.org/13219005/diff/1/webkit/dom_storage/dom_storage_area.h#newcode12 > ...
7 years, 9 months ago (2013-03-28 21:06:24 UTC) #5
brettw
7 years, 8 months ago (2013-03-29 19:21:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 manually as r191421 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698