Issue 1321883002: Replace signed char with int8_t. Fix Linux ARM build after r7830e9e.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1321883002: Replace signed char with int8_t. Fix Linux ARM build after r7830e9e. (Closed)

Created:
5 years, 3 months ago by Lei Zhang

Modified:
5 years, 3 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Replace signed char with int8_t. Fix Linux ARM build after r7830e9e. TBR=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5e4a5cc9ad76dc08d62fb1e10bdfb811f3720c43

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -22 lines)			Patch
	M	core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h	View		4 chunks	+6 lines, -6 lines	1 comment	Download
	M	core/src/fxcodec/jbig2/JBig2_GeneralDecoder.cpp	View		6 chunks	+14 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

TBR https://codereview.chromium.org/1321883002/diff/1/core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h File core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h (left): https://codereview.chromium.org/1321883002/diff/1/core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h#oldcode62 core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h:62: char GBAT[8]; Whoops, doesn't work for the Linux ...

5 years, 3 months ago (2015-08-29 06:42:47 UTC) #1

Lei Zhang

5 years, 3 months ago (2015-08-29 06:43:14 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5e4a5cc9ad76dc08d62fb1e10bdfb811f3720c43 (presubmit successful).

Expand Messages | Collapse Messages