Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 132183004: Include 2x assets when enable_hidpi=1 is specified on linux_aura (Closed)

Created:
6 years, 11 months ago by oshima
Modified:
6 years, 11 months ago
Reviewers:
tony, Elliot Glaysher
CC:
chromium-reviews
Visibility:
Public.

Description

Include 2x assets when enable_hidpi=1 is specified on linux_aura BUG=143619 R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244302

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/base/resource/resource_bundle.cc View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
oshima
6 years, 11 months ago (2014-01-10 01:23:03 UTC) #1
Elliot Glaysher
lgtm (Though I don't really understand how hidpi works in general. I'm just sort of ...
6 years, 11 months ago (2014-01-10 02:09:24 UTC) #2
oshima
tony -> owners
6 years, 11 months ago (2014-01-10 02:19:01 UTC) #3
tony
LGTM https://codereview.chromium.org/132183004/diff/1/ui/base/resource/resource_bundle.cc File ui/base/resource/resource_bundle.cc (right): https://codereview.chromium.org/132183004/diff/1/ui/base/resource/resource_bundle.cc#newcode574 ui/base/resource/resource_bundle.cc:574: #elif defined(OS_LINUX) && defined(ENABLE_HIDPI) Nit: Maybe merge this ...
6 years, 11 months ago (2014-01-10 17:38:27 UTC) #4
oshima
https://codereview.chromium.org/132183004/diff/1/ui/base/resource/resource_bundle.cc File ui/base/resource/resource_bundle.cc (right): https://codereview.chromium.org/132183004/diff/1/ui/base/resource/resource_bundle.cc#newcode574 ui/base/resource/resource_bundle.cc:574: #elif defined(OS_LINUX) && defined(ENABLE_HIDPI) On 2014/01/10 17:38:27, tony wrote: ...
6 years, 11 months ago (2014-01-10 18:46:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/132183004/1
6 years, 11 months ago (2014-01-10 18:50:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/132183004/1
6 years, 11 months ago (2014-01-10 23:34:33 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 01:59:52 UTC) #8
Message was sent while issue was closed.
Change committed as 244302

Powered by Google App Engine
This is Rietveld 408576698