Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 132183003: Add swipe_to_dismiss to Silk benchmark (Closed)

Created:
6 years, 11 months ago by abarth-chromium
Modified:
6 years, 11 months ago
Reviewers:
nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Add swipe_to_dismiss and stress_hidey_bars to Silk benchmark This CL adds two tests to the Silk benchmark: 1) swipe_to_dismiss. In this effect, a message is dismissed from the inbox by swiping it to the left. 2) stress_hidey_bars. In this effect, the messages pane is scrolled down, up, and then down again, which provokes the hidey bars to hide, appear, and then hide again. I've also updated inbox_app.html to the latest version. For some reason, the slide_drawer test is broken with the new verision of the app. I've left an old_inbox_app.html for that test case, but we should investigate why the test case doesn't work with the new code. R=nduca@chromium.org BUG=332439 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244087

Patch Set 1 #

Patch Set 2 : Also stress hidey bars #

Patch Set 3 : Adjust constants to work on Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -8 lines) Patch
M tools/perf/page_sets/key_silk_cases.json View 1 2 2 chunks +54 lines, -1 line 0 comments Download
M tools/perf/page_sets/key_silk_cases/inbox_app.html View 8 chunks +125 lines, -8 lines 0 comments Download
A + tools/perf/page_sets/key_silk_cases/old_inbox_app.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
abarth-chromium
6 years, 11 months ago (2014-01-09 22:22:14 UTC) #1
nduca
lgtm
6 years, 11 months ago (2014-01-09 22:33:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/132183003/1
6 years, 11 months ago (2014-01-09 22:41:34 UTC) #3
abarth-chromium
I added a test for stressing the hidey bars.
6 years, 11 months ago (2014-01-09 22:52:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/132183003/100001
6 years, 11 months ago (2014-01-09 22:59:24 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on win_x64_rel HTTP Error 400: Bad Request
6 years, 11 months ago (2014-01-09 23:19:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/132183003/90002
6 years, 11 months ago (2014-01-09 23:23:06 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=111392
6 years, 11 months ago (2014-01-10 01:23:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/132183003/90002
6 years, 11 months ago (2014-01-10 01:47:32 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 04:55:16 UTC) #10
Message was sent while issue was closed.
Change committed as 244087

Powered by Google App Engine
This is Rietveld 408576698