Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1321823004: Stop processing menuListValueChanged events. (Closed)

Created:
5 years, 3 months ago by David Tseng
Modified:
5 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop processing menuListValueChanged events. This event gets fired upon the popup button that hosts the menulist. In processing this event, we output feedback that stomps on a focus event (which targets the desired selected menulist option). BUG=525648 Committed: https://crrev.com/dea933d1078eec09cab3a788eb9c6d5ea99ee4b1 Cr-Commit-Position: refs/heads/master@{#347822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
David Tseng

5 years, 3 months ago (2015-09-08 21:51:31 UTC) #2
dmazzoni
lgtm
5 years, 3 months ago (2015-09-08 22:49:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321823004/1
5 years, 3 months ago (2015-09-08 22:50:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 23:18:18 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 23:19:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dea933d1078eec09cab3a788eb9c6d5ea99ee4b1
Cr-Commit-Position: refs/heads/master@{#347822}

Powered by Google App Engine
This is Rietveld 408576698