Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1321803003: ipc: Make sure that ChannelReader is destroyed correctly. (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@ipc_add_header4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Make sure that ChannelReader is destroyed correctly. ChannelReader observes the attachment broker, which it gets from a subclass. Before the subclass is destroyed, ChannelReader must stop observing the attachment broker. BUG=493414 Committed: https://crrev.com/53d919d2be1e9ef8e1b728efcc4f18351235d67f Cr-Commit-Position: refs/heads/master@{#348421}

Patch Set 1 #

Patch Set 2 : Rebase to pick up compile fixes. #

Patch Set 3 : Rebase to pick up compile errors. #

Patch Set 4 : Rebase to pick up compile fixes. #

Patch Set 5 : Rebase to fix compile errors. #

Patch Set 6 : Rebase against top of tree. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M ipc/ipc_channel_nacl.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel_reader.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/ipc_channel_reader.cc View 1 2 3 4 5 2 chunks +8 lines, -2 lines 0 comments Download
M ipc/ipc_channel_win.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 35 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321803003/1
5 years, 3 months ago (2015-08-28 20:43:43 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/75447)
5 years, 3 months ago (2015-08-28 20:54:57 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321803003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321803003/20001
5 years, 3 months ago (2015-08-28 21:07:57 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/76802)
5 years, 3 months ago (2015-08-28 21:39:44 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321803003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321803003/40001
5 years, 3 months ago (2015-08-28 21:46:46 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321803003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321803003/60001
5 years, 3 months ago (2015-08-28 22:56:25 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/97537)
5 years, 3 months ago (2015-08-28 23:39:36 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321803003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321803003/80001
5 years, 3 months ago (2015-08-29 00:25:00 UTC) #16
erikchen
5 years, 3 months ago (2015-08-29 00:47:09 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/105483)
5 years, 3 months ago (2015-08-29 01:26:43 UTC) #20
Tom Sepez
lgtm
5 years, 3 months ago (2015-09-10 15:20:35 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321803003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321803003/100001
5 years, 3 months ago (2015-09-10 18:28:55 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/105465)
5 years, 3 months ago (2015-09-10 19:18:52 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321803003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321803003/100001
5 years, 3 months ago (2015-09-10 19:26:47 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/111321)
5 years, 3 months ago (2015-09-10 20:15:10 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321803003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321803003/100001
5 years, 3 months ago (2015-09-11 17:04:12 UTC) #32
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 3 months ago (2015-09-11 17:33:42 UTC) #33
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/53d919d2be1e9ef8e1b728efcc4f18351235d67f Cr-Commit-Position: refs/heads/master@{#348421}
5 years, 3 months ago (2015-09-11 17:34:23 UTC) #34
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:23:32 UTC) #35
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/53d919d2be1e9ef8e1b728efcc4f18351235d67f
Cr-Commit-Position: refs/heads/master@{#348421}

Powered by Google App Engine
This is Rietveld 408576698