Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1321783002: Throw exceptions for charnum == getNumberOfChars in get{...}OfChar APIs (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, f(malita), gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Throw exceptions for charnum == getNumberOfChars in get{...}OfChar APIs According to the spec [1], IndexSizeError should be thrown if: "...the charnum is negative or if charnum is greater than or equal to the number of characters at this node." This is what's implemented by IE, Gecko and Presto. [1] http://www.w3.org/TR/SVG11/text.html#__svg__SVGTextContentElement__getStartPositionOfChar The current SVG2 draft has a different formulation: (https://svgwg.org/svg2-draft/text.html#__svg__SVGTextContentElement__getStartPositionOfChar) "If cluster is null, then then throw a DOMException with code INDEX_SIZE_ERR." but will have the same result. BUG=391345 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -4 lines) Patch
M LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html View 2 chunks +17 lines, -0 lines 0 comments Download
M LayoutTests/svg/text/svgtextcontentelement-methods-parameters-expected.txt View 2 chunks +13 lines, -0 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
Interop triviality
5 years, 3 months ago (2015-08-28 14:51:42 UTC) #2
f(malita)
lgtm
5 years, 3 months ago (2015-08-28 15:00:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321783002/1
5 years, 3 months ago (2015-08-28 15:28:48 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 17:16:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201411

Powered by Google App Engine
This is Rietveld 408576698